Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Call Graph [WIP] #605

Closed
wants to merge 21 commits into from
Closed

Add Call Graph [WIP] #605

wants to merge 21 commits into from

Conversation

Amejonah1200
Copy link
Contributor

@Amejonah1200 Amejonah1200 commented Sep 25, 2022 •
edited
Loading

recaf

TODO:

  • Call Graph Docking
    • Move to own Window
    • Bundle in one TabPane for Docking
    • Refocus of method (navigation)
  • Method Handles (?)
  • Dynamic methods
  • Fix NPE
  • Support for workspace updates:
    • Add Library
    • Add new class
    • Update Class
    • Delete Class
    • Remove Library
  • LinkerResolver caching
  • Show unresolved calls
  • Threading Issues?
  • Cache ClassInfo?
  • Optimize renaming and other changes that affect this feature
  • Make Toggle for Call Graph

@Amejonah1200
Copy link
Contributor Author

This PR is stuck, as it needs an inheritance graph which can resolve methods correctly compliant with JVM behavior.
https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-5.html#jvms-5.4.3.3

@Amejonah1200
Copy link
Contributor Author

Thanks to @xxDark with https://jitpack.io/#xxDark/jlinker , I will try to implement further calls.

@Amejonah1200
Copy link
Contributor Author

Amejonah1200 commented Oct 23, 2022 •
edited
Loading

On another note, I will probably switch to a standalone tab/window (dock) instead of it being at the right.

@Col-E Col-E mentioned this pull request Jan 24, 2023
Closed
@Col-E
Copy link
Owner

Col-E commented Jun 22, 2023

Migrated to new branch under: https://github.com/Col-E/Recaf/tree/dev4/recaf-api/src/main/java/software/coley/recaf/services/callgraph

Anything seem to be missing?

@Col-E
Copy link
Owner

Col-E commented Jun 23, 2023 •
edited
Loading

image

Feedback from xDark, can address on dev4

image

Feedback from Amejonah

@Amejonah1200 Amejonah1200 marked this pull request as ready for review August 20, 2023 19:17
@Amejonah1200
Copy link
Contributor Author

image
There are reports, these colors are not very suitable. If someone can give better ones, I would gladly accept and integrate.

Otherwise, I would put this as ready to be merged.

@Amejonah1200 Amejonah1200 marked this pull request as draft August 29, 2023 11:43
@Amejonah1200
Copy link
Contributor Author

Amejonah1200 commented Aug 29, 2023 •
edited
Loading

image
When renaming a method, it slows down. Needs more investigation.

@Col-E
Copy link
Owner

Col-E commented Jun 12, 2024 •
edited
Loading

Its finally been ported over to dev4 🥳

2acd33a

@Col-E
Copy link
Owner

Col-E commented Jun 16, 2024

Closing now that 4.X has the same functionality, we can continue from there rather than on this 3.X branch

@Col-E Col-E closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Col-E Col-E Col-E left review comments

Assignees
No one assigned
Labels
3.X enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amejonah1200 @Col-E