Preview 1.82.2 Release #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100% reviewed source file: 'en_US.json' on 'es_419'.
The server running is using a local dinky server, pls no abooze. TODO: Implement Sentry catcher to ALL EXCEPTION HOLY THAT IS A LOT
100% reviewed source file: 'en_US.json' on 'zh_CN'.
`USEREMOTELOGGING`, automatically enabled on Preview & Debug branches for obvious reasons. update logger types
Does not initialize or de-initialize the utility. Note: An app restart may be required when selecting the option
sends it to Sentry so we don't have to refactor all our exception calls
Move SentrySDK init to its own helper
…nts' into sentry-error-collection
This added current log for when exception is sent to Dsn
1. Redacted username in the log file when its not debug build 2. Properly dispose SentrySdk when toggled off 3. Pipe SentrySdk log to Logger 4. Use correct flusher for SentryHelper.cs 5. Fixed cleaner loop for ExceptionHandler_ForLoop by @neon-nyan Co-authored-by: Kemal Setya Adhi <dev.kemalsetyaa@gmail.com>
No need for adding Sentry's ExceptionHandler on catcher that has SendException already
Grabbed from Velopack's Implementation with adjustments to make the COM Interop compatible with AOT/Trim
100% reviewed source file: 'en_US.json' on 'ja_JP'.
Note: - Some submodules cannot import SentryHelper, which is in `Hi3Helper.Core` - Some calls are asynchronous, mostly for the handled exceptions, but also where it felt best to use them, feel free to change them if needed - Most are categorized as `UnhandledOther`, but if we feel the need to change some, we can, it simply affects tagging on the frontend dashboard.
…embly (#606) # Main Goal As you might already know, Collapse heavily relies on native invocation for some libraries, especially when it is communicating with Win32 APIs. For more than two years, we have been using the ``[DllImport]`` attribute to define the external method to call the native functions of certain libraries (especially when it comes to `Win32` calls). In .NET 7, ``[LibraryImport]`` was introduced, which is the ``[DllImport]`` alternative that provides the source-generated invocation to native functions, instead of using a JIT-ed approach. The ``[LibraryImport]`` brings some invocation features which aren't available for NativeAOT compilations, for example: ``GetLastWin32Error()``, which is useful when diagnosing what's wrong when a `Win32` function is getting called. Read more about ``[LibraryImport]`` here: https://learn.microsoft.com/en-us/dotnet/standard/native-interop/pinvoke-source-generation https://learn.microsoft.com/en-us/dotnet/standard/native-interop/best-practices Another reason for these changes are for maintainability and to share some of the same functionality between our projects. This changes can improve the work time efficiency and reusability of the functions between methods without making or implementing the same methods with the same functionality between modules. ## PR Status : - Overall Status : Completed - Commits : Completed - Synced to base (Collapse:main) : Yes - Build status : OK - Crashing : No - Bug found caused by PR : Unsure ### Templates <details> <summary>Changelog Prefixes</summary> ``` **[New]** **[Imp]** **[Fix]** **[Loc]** **[Doc]** ``` </details>
This reverts commit 7e504b2.
- Use built-in ToHexStringLower for BytesToHex - Fix SharedViolation exception by unassigning ReadOnly attribute - Simplify and remove unnecessary Stream bridge - Add and use alt. SophonChunksInfo if the default url returns 404 This to fix an issue where sometimes the chunk files would return 404 due to identical chunks but was not existence in the new ChunksInfo - Always check for file availability on enumerating updates - Fix non-exist files not getting renamed on update - More UnassignReadOnlyFromFileInfo() checks - Fix wrong URL path for manifestToProtoTaskCallback - Reuse Proto Parser Code
…ileNotFoundException Try to delete and reassign them as missing file
Following infos will be sent: 1. Build info (Commit, Repo, Branch) 2. Currently loaded game info (Category, Region, Installed, Updated, Has Preload/Delta)
# Main Goal Use poster as temporary background when requested background is not yet downloaded. New background retrieval mechanism: 1. Check if background is downloaded 2. If it's downloaded, then load the downloaded background 3. If not yet downloaded, load either last available regional background or use poster as background instead Due to the poster having slight transparency, the switching looks a wee bit janky This PR also contains IOException fixes especially for background loading and image cache processing (really noticeable when user uses Waifu2X) ## PR Status : - Overall Status : Done - Commits : Done - Synced to base (Collapse:main) : Yes - Build status : OK - Crashing : No - Bug found caused by PR : 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed? - 1.82.2
Stream..GetAsync()on gettingHttpResponseMessage.Convert.ToHexStringLower()to convertbyte[]orReadOnlySpan<byte>to Hex string.Changelog Prefixes