Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
check_comfy_repo
is returningTuple[bool, Optional[git.Repo]]
, but most call site is treating the return value as a bool, so the check at most callsites just always pass, because the a tuple of 2 items always evals to True.This PR does following changes:
check_comfy_repo
toget_comfy_repo
as the git.Repo is the most important return valueOptional[git.Repo]
as the bool can be obtained from nullity ofOptional[git.Repo]
Note:
This will likely break things. So don't merge it until we have more test coverage.