Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a --fast-deps option to comfy install/reinstall that enables new faster/unified/uv-based dependency install #141

Merged
merged 30 commits into from
Aug 16, 2024
Merged

Add a --fast-deps option to comfy install/reinstall that enables new faster/unified/uv-based dependency install #141

merged 30 commits into from
Aug 16, 2024

Commits on Aug 2, 2024

  1. added uv script

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    7e61541 View commit details
    Browse the repository at this point in the history

  2. --fast-deps option now works with installing comfyui core and comfyui… 

    …-manager
    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3f0b106 View commit details
    Browse the repository at this point in the history

  3. comfy node install --fast-deps is now supported

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4f08f72 View commit details
    Browse the repository at this point in the history

  4. --fast-deps installs of core/nodes now auto-detect gpu if torch i… 

    …s already installed
    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3449db5 View commit details
    Browse the repository at this point in the history

  5. added section on developing comfy-cli and ComfyUI-Manager together

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    66bcfdb View commit details
    Browse the repository at this point in the history

  6. clean up specification of --fast-deps option

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    2a57a70 View commit details
    Browse the repository at this point in the history

  7. fix python 3.9 incompatible type hint syntax

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4cc4241 View commit details
    Browse the repository at this point in the history

  8. picked lint

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d0c271d View commit details
    Browse the repository at this point in the history

  9. post rebase cleanup

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    09f1883 View commit details
    Browse the repository at this point in the history

  10. make DependencyCompiler more flexible/testable

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    54f3d40 View commit details
    Browse the repository at this point in the history

  11. fix routine for finding custom node dirs

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    de64035 View commit details
    Browse the repository at this point in the history

  12. remove awkward fastInstallComfyDeps shim function

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    00e447e View commit details
    Browse the repository at this point in the history

  13. mark staticmethods with UpperCamelCase names

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0773ed0 View commit details
    Browse the repository at this point in the history

  14. cleanup DependencyCompiler.InstallBuildDeps

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    5baac22 View commit details
    Browse the repository at this point in the history

  15. started adding tests for code in uv.py module

    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    a7866ad View commit details
    Browse the repository at this point in the history

  16. test_uv now runs, dies on mock extension vs extension dependency conf… 

    …lict
    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    643f4ae View commit details
    Browse the repository at this point in the history

  17. uv subprocess calls now print cmd/output on error 

    - output is currently unsatisfactory in the case of a dependency conflict
  - doesn't print the names of conflicting top-level packages. The uv maintainers have expressed interest in fixing this: astral-sh/uv#1854
    @telamonian
    telamonian committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    73396ce View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. add parsing of uv compile conflict error

    @telamonian
    telamonian committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    17e2e47 View commit details
    Browse the repository at this point in the history

  2. add resolve_strategy="ask" option to DependencyCompiler.Compile 

    - will manually prompt user for resolution in case of extension-vs-extension dependency conflict, using `ui.prompt_select`
    @telamonian
    telamonian committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c5d696b View commit details
    Browse the repository at this point in the history

  3. basic implementation of ext-vs-ext conflict resolution via manual use… 

    …r input now functional

- needs better output
    @telamonian
    telamonian committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    2efb3a7 View commit details
    Browse the repository at this point in the history

  4. improved feedback/UX of manual dependency conflict resolution

    @telamonian
    telamonian committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c92fc85 View commit details
    Browse the repository at this point in the history

  5. fixup user input for conflict resolution; fixup test-uv paths

    @telamonian
    telamonian committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    699505e View commit details
    Browse the repository at this point in the history

  6. test_compile in test_uv now works/runs correctly via pytest 

    - still needs an actual assert at the end
    @telamonian
    telamonian committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    2825212 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. added assert to test_compile. Might still be a bit fragile

    @telamonian
    telamonian committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4295769 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. made test_compile more robust

    @telamonian
    telamonian committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    98b6238 View commit details
    Browse the repository at this point in the history

  2. small type hint fix

    @telamonian
    telamonian committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5c9b379 View commit details
    Browse the repository at this point in the history

  3. mark old py dep install funcs with pip_ prefix

    @telamonian
    telamonian committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5a81f65 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. in uv.py, make func/methods snake_case, static methods Snake_Case

    @telamonian
    telamonian committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    41de4c5 View commit details
    Browse the repository at this point in the history

  2. ci test fix

    @telamonian
    telamonian committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    c87cb3d View commit details
    Browse the repository at this point in the history

  3. disable nuisance lint rule (W0707)

    @telamonian
    telamonian committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ce67400 View commit details
    Browse the repository at this point in the history