-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for ruff linting and autoformatting #149
Conversation
Are we nuking the current setup of linting with pylint and autoformatting with black? |
@huchenlei That's the idea. ruff alone can handle both linting and formatting (it has tools for both). It should also support more features/rules and be much more flexible than black. Oh, and also be much faster, thanks to the fact that it's written in rust. The only real downside that I can think of is that, being written in rust, it will be harder for us to contribute back upstream. Which hopefully shouldn't be too relevant for us |
0756701
to
e7300aa
Compare
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore pypi/ruff@0.6.1 |
No need to worry about the failure of the ruff_check GA, that gets fixed when the initial ruff lint/format is applied in #157 |
No description provided.