Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for ruff linting and autoformatting #149

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

telamonian
Copy link
Member

No description provided.

@huchenlei
Copy link
Member

Are we nuking the current setup of linting with pylint and autoformatting with black?

@telamonian
Copy link
Member Author

telamonian commented Aug 8, 2024

Are we nuking the current setup of linting with pylint and autoformatting with black?

@huchenlei That's the idea. ruff alone can handle both linting and formatting (it has tools for both). It should also support more features/rules and be much more flexible than black.

Oh, and also be much faster, thanks to the fact that it's written in rust. The only real downside that I can think of is that, being written in rust, it will be harder for us to contribute back upstream. Which hopefully shouldn't be too relevant for us

Copy link

socket-security bot commented Aug 17, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/ruff@0.6.1 environment, eval, filesystem, network, shell, unsafe 0 32.8 MB astral-bot, crmarsh, zanie

View full report↗︎

Copy link

socket-security bot commented Aug 17, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@telamonian telamonian marked this pull request as ready for review August 17, 2024 02:09
@telamonian
Copy link
Member Author

@SocketSecurity ignore pypi/ruff@0.6.1

@telamonian
Copy link
Member Author

No need to worry about the failure of the ruff_check GA, that gets fixed when the initial ruff lint/format is applied in #157

@telamonian telamonian merged commit d7c0f52 into Comfy-Org:main Aug 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants