-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builder for standalone python for comfy #158
Merged
telamonian
merged 11 commits into
Comfy-Org:main
from
telamonian:add-standalone-builder
Aug 23, 2024
Merged
Add builder for standalone python for comfy #158
telamonian
merged 11 commits into
Comfy-Org:main
from
telamonian:add-standalone-builder
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
robinjhuang
reviewed
Aug 22, 2024
telamonian
force-pushed
the
add-standalone-builder
branch
2 times, most recently
from
August 23, 2024 12:17
ab56578
to
cc7e6a3
Compare
This PR is now out of draft status, is more-or-less feature complete, and is ready for testing. Especially if you have a windows machine, please checkout this PR branch and try out the new There is still a ton of cleanup to do, and any suggestions are welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command
comfy-cli standalone
that will:3a. install all requirements to the standalone's internal site-packages directory
3b. precache the package artifacts of all requirements
3c. fetch (if exists) or build the wheels of all requirements
.tgz
tarball containing the standalone interpreter and the requirementsCode exists to run all of 3a-c, though currently the
standalone
command itself only supports 3b.