Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder for standalone python for comfy #158

Merged
merged 11 commits into from
Aug 23, 2024

Conversation

telamonian
Copy link
Member

@telamonian telamonian commented Aug 20, 2024

Adds a command comfy-cli standalone that will:

  1. grab an appropriate standalone python interpreter from https://github.com/indygreg/python-build-standalone
  2. determine requirements by analyzing an existing comfyui install and then recompile the requirements W.R.T. the version/platform/whatever of the standalone python interpreter
  3. fetch all comfyui requirements for the standalone python interpreter by doing one of
    3a. install all requirements to the standalone's internal site-packages directory
    3b. precache the package artifacts of all requirements
    3c. fetch (if exists) or build the wheels of all requirements
  4. create a .tgz tarball containing the standalone interpreter and the requirements

Code exists to run all of 3a-c, though currently the standalone command itself only supports 3b.

Copy link

socket-security bot commented Aug 20, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/uv@0.3.2 environment, filesystem, network, shell, unsafe 0 36.8 MB astral-bot, crmarsh, zanie

View full report↗︎

@telamonian telamonian force-pushed the add-standalone-builder branch 2 times, most recently from ab56578 to cc7e6a3 Compare August 23, 2024 12:17
@telamonian telamonian marked this pull request as ready for review August 23, 2024 17:00
@telamonian
Copy link
Member Author

This PR is now out of draft status, is more-or-less feature complete, and is ready for testing. Especially if you have a windows machine, please checkout this PR branch and try out the new standalone command.

There is still a ton of cleanup to do, and any suggestions are welcome

@telamonian telamonian merged commit 7ce59eb into Comfy-Org:main Aug 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants