Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt dialog improvements #18

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Jul 14, 2024

  • Use widget's type to set the type of dialog inputs. If it's a number, pass the min, max, and step options as well. From ComfyUI#1612

    Switching those inputs to type="number" and adding step="0.05" would show the arrows, and allow keyboard up/down arrows and mouse wheel to change the value in 0.05 increments/decrements. Also, min and max attributes can limit the values whenever needed. Having to manually type values while you could use the mouse wheel to change them is rather cumbersome.
    Selection_049

  • Close widget prompt dialogs by clicking canvas. From ComfyUI#90

  • Allow closing with touch event. Currently if the dialog is rendered offscreen on touch device, there is no way to get rid of it other than refreshing

  • ComfyUI#1023 is also fixed

@christian-byrne
Copy link
Contributor Author

Separated into #80 for closing prompt dialog and #81 for number inputs.

@christian-byrne christian-byrne deleted the click-close-prompt-dialogs branch August 21, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant