[Experiment] Initial CompositionCollectionView implementation and basic samples #277

arcadiogarcia · 2022-09-19T05:38:39Z

This PR contains the initial implementation of the CompositionCollectionView control proposed in #135. More specifically, it implements:

CompositionCollectionView XAML control
Layout and LayoutBehavior as the extensible base class for layouts and their behaviors
InteractionTrackerBehavior, the first (of hopefully many) general purpose behavior, to easily plug InteractionTrackers into layouts
- This also includes InteractionTrackerElementBehavior for per-element interaction trackers, and InteractionTrackerGesture for defining reusable InteractionTrackerGestures
- A few basic samples

CommunityToolkit.Labs_.CompositionCollectionView.Sample.2022-09-18.22-29-20.mp4

I'd like to check this in as an initial version of the control so it can be pulled into apps easily and tried by other people. While the public interfaces might undergo changes and I plan to add more behaviors and samples, functionality wise the control is feature complete. I still need to add tests and document each method too.

Other caveats:

The current implementation only supports UWP. The long term plan is to eventually also support Reunion but I haven't gotten around to testing that. Support for other platforms that do not support Composition are out of the scope of this control though.
This control relies heavily on the ExpressionNodes from the Community Toolkit, to which I had to add a couple extra features. Since that part of the library is not accepting new features right now, this experiment also contains a fork of that part of the library with my changes, the long term plan would be to eventually merge this fork. (See Add Evaluate() method to expression nodes WindowsCommunityToolkit#4559)

… into feature/compositionCollectionView

…tionCollectionView2

michael-hawker

Looks like there's a back-up csproj file committed as well.

Haven't had a chance to try it out, but wanted to provide a few high-level comments first. Thanks for the PR!

@Arlodotexe do we have an easy way to exclude something entirely from Uno at the moment?

labs/CompositionCollectionView/src/CompositionCollectionView.cs

michael-hawker · 2022-09-19T21:17:27Z

labs/CompositionCollectionView/src/Layout.cs

+}
+
+#if !WINAPPSDK
+public abstract partial class Layout<TId, TItem> : ILayout, IDisposable


Layout conflicts with the base ItemsRepeater Layout class and is too generic here (which is why you probably ran into immediate issues in WindowsAppSDK land). This should be more like CompositionCollectionLayout or something. Maybe we need a more concise name for the layout itself?

Sounds good, also I'm flexible about naming in general, if someone suggests something that rolls off the tongue better than CompositionCollectionView I'm happy to rename it

labs/CompositionCollectionView/src/Layout.cs

Arlodotexe · 2022-09-26T23:32:03Z

@Arlodotexe do we have an easy way to exclude something entirely from Uno at the moment?

We don't (yet) have a way to disable a component under a specific platform.

The expectation so far is that Labs experiments may not be production ready, but once it is, components should work on as many platforms as reasonably possible.

So far, we haven't come across any experiment that will never run under a specific platform, but we can (and should) in the future if it becomes a hard blocker.

arcadiogarcia · 2022-09-28T03:44:15Z

So far, we haven't come across any experiment that will never run under a specific platform, but we can (and should) in the future if it becomes a hard blocker.

I'm afraid this might be the first experiment that falls in that bucket, because it depends heavily on the composition animation API and as far as I can tell Uno doesn't have any plans to add support for those anytime soon. (They mentioned it as a required feature in the Animation for Android epic (unoplatform/uno#5586, which hasn't seen much activity lately and isn't added to any milestone, and it isn't even mentioned at all in the Animation for WASM epic unoplatform/uno#3919)

…rting old value

michael-hawker · 2022-10-31T05:22:00Z

We definitely need to figure out some story around documenting and calling out supported platforms within Labs, even if we expect stuff to get Uno support later, it may not start out that way. @Arlodotexe something for us to start discussing as we plan for 8.0.

@arcadiogarcia want to run XAML Styler with the settings in the repository (there's also a script in the repo root) so that the rest of the build will run?

Arlodotexe · 2023-02-24T18:00:04Z

@arcadiogarcia Do you know why the source project has a shared project in it? This isn't part of our template 🤔

michael-hawker · 2023-02-24T23:52:12Z

Note, this is also another project which only works on UWP/WinAppSDK, so we'll need whatever fix we do for the #353 to not generate the wasm single project head here as well.

arcadiogarcia · 2023-03-10T04:51:09Z

@arcadiogarcia Do you know why the source project has a shared project in it? This isn't part of our template 🤔

I don't remember tbh. Probably I was trying something and forgot to remove it, as far as I can tell is not important, I deleted it.

michael-hawker · 2023-03-10T22:28:53Z

@arcadiogarcia sorry things keep changing underneath you, there's a lot of moving parts still and we're trying to push forward to be able to split our infrastructure out to reuse. Hopefully things will settle down.

Saw there's changes to the global usings file, so there's a conflict now. Most of that seems fine, though we have an open item to refactor that process CommunityToolkit/Tooling-Windows-Submodule#15.

Your changes seem fine, though I am a bit weary of including Windows.UI globally for both UWP and WASDK all-up. Maybe you could have that one just in the files you need it for this PR?

arcadiogarcia · 2023-03-11T22:38:46Z

@arcadiogarcia sorry things keep changing underneath you, there's a lot of moving parts still and we're trying to push forward to be able to split our infrastructure out to reuse. Hopefully things will settle down.

Saw there's changes to the global usings file, so there's a conflict now. Most of that seems fine, though we have an open item to refactor that process CommunityToolkit/Tooling-Windows-Submodule#15.

Your changes seem fine, though I am a bit weary of including Windows.UI globally for both UWP and WASDK all-up. Maybe you could have that one just in the files you need it for this PR?

Sure no worries! I removed the global Windows.Ui using and ran the xaml styler on my files, let me know if there's anything else I should fix. I see a few other failures on the checks but as far as I can tell they seem unrelated to this PR.

arcadiogarcia · 2023-03-11T22:47:10Z

Btw should I expect to see the nuget package in the PR feed already? (https://pkgs.dev.azure.com/dotnet/CommunityToolkit/_packaging/CommunityToolkit-PullRequests/nuget/v3/index.json) I see that the new-experiment build succeeds but I don't see the nuget in the feed, do I have to fix something else for it to get published there?

Arlodotexe · 2023-03-13T20:48:35Z

I see a few other failures on the checks but as far as I can tell they seem unrelated to this PR.

That's odd. This isn't present on main, and the branch is already up to date with main. Maybe a merge issue? I'll fix it manually for now.

michael-hawker · 2023-03-13T21:53:07Z

Looks like the error messages on the build are all this:

Error: /home/runner/work/Labs-Windows/Labs-Windows/components/MarqueeText/src/MarqueeText.Properties.cs(53,12): error CS0246: The type or namespace name 'RepeatBehavior' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/Labs-Windows/Labs-Windows/components/MarqueeText/src/CommunityToolkit.Labs.WinUI.MarqueeText.csproj]
Error: /home/runner/work/Labs-Windows/Labs-Windows/components/MarqueeText/src/MarqueeText.cs(54,13): error CS0246: The type or namespace name 'Storyboard' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/Labs-Windows/Labs-Windows/components/MarqueeText/src/CommunityToolkit.Labs.WinUI.MarqueeText.csproj]

Which is weird as that's a different experiment...

michael-hawker · 2023-03-13T23:19:23Z

components/CompositionCollectionView/src/Dependencies.WinUI2.props

@@ -0,0 +1,20 @@
+<!--


@Arlodotexe these are remnants of the old system...

Also we're missing the multi-target props, so think that's why we're seeing the Uno warnings/errors, eh?

D:\a\Labs-Windows\Labs-Windows\components\CompositionCollectionView\src\Behaviors\InteractionTrackerGesture\GesturePreviewControl.cs(8,23): error CS0260: Missing partial modifier on declaration of type 'GesturePreviewControl'; another partial declaration of this type exists [D:\a\Labs-Windows\Labs-Windows\components\CompositionCollectionView\src\CommunityToolkit.Labs.WinUI.CompositionCollectionView.csproj] D:\a\Labs-Windows\Labs-Windows\components\CompositionCollectionView\src\CompositionCollectionView.cs(11,21): error CS0260: Missing partial modifier on declaration of type 'CompositionCollectionView'; another partial declaration of this type exists [D:\a\Labs-Windows\Labs-Windows\components\CompositionCollectionView\src\CommunityToolkit.Labs.WinUI.CompositionCollectionView.csproj]

michael-hawker · 2023-03-13T23:21:07Z

common/GlobalUsings_WinUI.cs

-#endif
-
-global using MUXC = Microsoft.UI.Xaml.Controls;
+// Licensed to the .NET Foundation under one or more agreements.


Changes here are going to be a problem/conflict with the work we're doing for #405 and #398. Should just tie-in to clean up needed for #321?

michael-hawker · 2023-03-13T23:21:43Z

Windows.Toolkit.Common.props

@@ -9,7 +9,6 @@
    <Copyright>(c) .NET Foundation and Contributors.  All rights reserved.</Copyright>
    <PackageProjectUrl>https://github.com/CommunityToolkit/Labs-Windows</PackageProjectUrl>
    <PackageReleaseNotes>https://github.com/CommunityToolkit/Labs-Windows/releases</PackageReleaseNotes>
-    <PackageIcon>Icon.png</PackageIcon>


There's some other non-needed changes here and in the common\test projects

michael-hawker · 2023-03-13T23:23:29Z

...nents/CompositionCollectionView/src/ExpressionsFork/Expressions/ExpressionNodes/ColorNode.cs

@@ -0,0 +1,137 @@
+#nullable disable


License should still be top thing, does this tie into CS8602? Ideally we should just be good had writing nullable safe code, but probably easier to just do at project level in csproj and track via a todo later.

Nullability is worth doing a pass on before merging in here. This PR will already be nontrivial to bring up to date with our latest tooling.

michael-hawker · 2023-03-13T23:24:04Z

...CollectionView/src/ExpressionsFork/Expressions/ExpressionValues/ExpressionValues.Constant.cs

+using System.Numerics;
+using Windows.UI;
+
+namespace Microsoft.Toolkit.Uwp.UI.Animations.ExpressionsFork


Do these things already exist in the toolkit? Can we not just reference them from the existing package?

This experiment needs the changes from my branch at CommunityToolkit/WindowsCommunityToolkit#4559, which we never merged to master, that's why I'm including my own fork that is evolving in parallel. I agree that adding a copy of those classes is not ideal, but there doesn't seem to be any good way to add functionality to those core toolkit classes from an experiment (I can't add the Evaluate() method as an extension method because it relies on private properties of the ExpressionNodes).

michael-hawker · 2023-03-13T23:25:11Z

components/CompositionCollectionView/src/IsExternalInit.cs

@@ -0,0 +1,17 @@
+// Licensed to the .NET Foundation under one or more agreements.


We should just use PolySharp reference for these. Were you using records somewhere?

PolySharp is included by default on the Uwp head. For component libraries, they need to be included on the project itself, see examples here.

michael-hawker · 2023-03-13T23:26:58Z

components/CompositionCollectionView/samples/BasicSample.xaml.cs

+            #endif
+        }
+
+#if !WINAPPSDK


Bit confused by these conditionals in the samples, there's no comment, why is this excluded on the WindowsAppSDK?

components/CompositionCollectionView/samples/CanvasSample.cs

michael-hawker · 2023-03-13T23:28:26Z

components/CompositionCollectionView/samples/CanvasSample.cs

@@ -0,0 +1,97 @@
+// Licensed to the .NET Foundation under one or more agreements.


This file should be CanvasSample.xaml.cs no?

Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>

arcadiogarcia added 15 commits July 6, 2022 21:00

CompositionCollectionView port and basic sample

d1b9aa1

Samples

8a959a9

Maze WIP

7cfe44d

Merge branch 'main' of https://github.com/CommunityToolkit/Labs-Windows…

6e9dcb6

… into feature/compositionCollectionView

CCV project

61be6d3

Merge branch 'feature/compositionCollectionView' into feature/composi…

028c635

…tionCollectionView2

Fix maze layout

11a1a43

Sample text

d9b54e3

Generic model

c63d0a4

Cleanup

7ebb3aa

Restore file from master

27c94d4

Disable code for non-UWP targets

1304e6c

Adjust colors

252b5be

Fix z index

efb3d1f

Fix xaml styling

7df0634

michael-hawker reviewed Sep 19, 2022

View reviewed changes

arcadiogarcia added 2 commits September 21, 2022 22:14

Address PR feedback

0dbd25e

Break down layout file

218ee1c

arcadiogarcia added 6 commits October 27, 2022 16:00

Report last state of interaction trackers + fix animatable nodes repo…

885cf60

…rting old value

WIP

cd5c508

Fix sample

b3ddd06

Increase version

86406e6

Remove IsUserInteracting property

39d744e

WIp

7c1774a

arcadiogarcia added 2 commits November 1, 2022 14:29

Fix transition bug

fa5cc2b

Run xaml styler

d55fb2b

michael-hawker linked an issue Nov 2, 2022 that may be closed by this pull request

🧪 [Experiment] CompositionCollectionView, a composition-driven collection view with fully customizable look and behavior #135

Open

29 tasks

arcadiogarcia and others added 10 commits November 17, 2022 16:00

Improve Evaluate not implemented error messages and implement Length()

78bd506

Merge branch 'main' into feature/compositionCollectionView2

75661bc

Updated with project changes from CommunityToolkit#327

635fb6d

Merge branch 'main' into feature/compositionCollectionView2

e8720e2

Updated with project changes from CommunityToolkit#330

5f128fb

Added missing discussion-id and issue-id to front matter

8d28c32

Merge branch 'main' into feature/compositionCollectionView2

d582d29

Migrating to new component folder layout

840e331

Merge branch 'main' into feature/compositionCollectionView2

b194ba7

Fixed compilation errors for tests

9aae744

Fixed compilation errors

c06af8c

arcadiogarcia added 2 commits March 9, 2023 20:33

Merged with local changes

05c6051

Remove extra shared project

790fdd0

Fix lerp implementation & compile error

8bac431

Arlodotexe and others added 4 commits March 10, 2023 18:00

Merge branch 'main' into feature/compositionCollectionView2

5421485

Merge fix

fdc41d6

Address feedback

9c2a469

Fix styling

6a0b6c0

Merge branch 'main' into feature/compositionCollectionView2

4024c1a

Add missing globalusing

5929330

michael-hawker requested changes Mar 13, 2023

View reviewed changes

Update components/CompositionCollectionView/samples/CanvasSample.cs

6f978ed

Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Experiment] Initial CompositionCollectionView implementation and basic samples #277

[Experiment] Initial CompositionCollectionView implementation and basic samples #277

arcadiogarcia commented Sep 19, 2022 •

edited

Loading

michael-hawker left a comment

michael-hawker Sep 19, 2022

arcadiogarcia Sep 22, 2022

Arlodotexe commented Sep 26, 2022

arcadiogarcia commented Sep 28, 2022 •

edited

Loading

michael-hawker commented Oct 31, 2022

Arlodotexe commented Feb 24, 2023

michael-hawker commented Feb 24, 2023

arcadiogarcia commented Mar 10, 2023

michael-hawker commented Mar 10, 2023

arcadiogarcia commented Mar 11, 2023

arcadiogarcia commented Mar 11, 2023

Arlodotexe commented Mar 13, 2023

michael-hawker commented Mar 13, 2023

michael-hawker Mar 13, 2023

michael-hawker Mar 13, 2023

michael-hawker Mar 13, 2023

michael-hawker Mar 13, 2023

Arlodotexe May 27, 2024

michael-hawker Mar 13, 2023

arcadiogarcia Mar 18, 2023

michael-hawker Mar 13, 2023

Arlodotexe May 27, 2024

michael-hawker Mar 13, 2023

michael-hawker Mar 13, 2023

		@@ -0,0 +1,17 @@
		// Licensed to the .NET Foundation under one or more agreements.

		@@ -0,0 +1,97 @@
		// Licensed to the .NET Foundation under one or more agreements.

[Experiment] Initial CompositionCollectionView implementation and basic samples #277

Are you sure you want to change the base?

[Experiment] Initial CompositionCollectionView implementation and basic samples #277

Conversation

arcadiogarcia commented Sep 19, 2022 • edited Loading

michael-hawker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Arlodotexe commented Sep 26, 2022

arcadiogarcia commented Sep 28, 2022 • edited Loading

michael-hawker commented Oct 31, 2022

Arlodotexe commented Feb 24, 2023

michael-hawker commented Feb 24, 2023

arcadiogarcia commented Mar 10, 2023

michael-hawker commented Mar 10, 2023

arcadiogarcia commented Mar 11, 2023

arcadiogarcia commented Mar 11, 2023

Arlodotexe commented Mar 13, 2023

michael-hawker commented Mar 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arcadiogarcia commented Sep 19, 2022 •

edited

Loading

arcadiogarcia commented Sep 28, 2022 •

edited

Loading