Fix TitleBar Sample mucking up App's TitleBar #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TitleBar if it was the initializer of the setup
Arlodotexe
approved these changes
Jul 2, 2024
niels9001
approved these changes
Jul 3, 2024
|
Tested on WinAppSDK, all is well. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add internal check for TitleBar code so that it only resets the App's TitleBar if it was the initializer of the setup originally
Before this change, if you opened the TitleBar sample the App's TitleBar customizations would be reset. After this change, that no longer occurs.
Needs to be checked with WASDK as well as that the default behavior is uneffected.