Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to WinAppSdk 1.6, fixed AoT annotations #457

Merged
merged 23 commits into from
Aug 24, 2024
Merged

Updated to WinAppSdk 1.6, fixed AoT annotations #457

merged 23 commits into from
Aug 24, 2024

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jul 31, 2024

@Arlodotexe Arlodotexe changed the title Fixing CSWinRT1028 warnings, adding partials for AoT. Updated to WinAppSdk 1.6, fixed AoT annotations Jul 31, 2024
@Arlodotexe Arlodotexe marked this pull request as draft July 31, 2024 23:10
@Arlodotexe Arlodotexe marked this pull request as ready for review August 7, 2024 01:03
@Arlodotexe
Copy link
Member Author

Getting a webview2 error now, tracking in the Labs PR: CommunityToolkit/Labs-Windows#561 (comment)

@michael-hawker
Copy link
Member

@Arlodotexe can we try this property from PowerToys (thanks @crutkas)? microsoft/PowerToys@main...dev/crutkas/testWinApp1.6p1#diff-47ade91915b4663302faffd533920a7af2359db7b717154c93a886448c0430c4R20-R29

<!-- START Upgrade Todo: Verify this is needed for RTM -->
	<PropertyGroup>
		<!-- Workaround for CWV2 SDK package bug referencing the winrt implementation binary (Microsoft.Web.WebView2.Core.dll)
       when TargetPlatform=AnyCPU (as in this project). We don't need it for the cswinrt projection, set flag to  avoid loading it. -->
		<WebView2EnableCsWinRTProjectionExcludeCoreRef>true</WebView2EnableCsWinRTProjectionExcludeCoreRef>
	</PropertyGroup>
	<!-- END Upgrade Todo: Verify this is needed for RTM -->


	<PropertyGroup>

@Arlodotexe
Copy link
Member Author

Now that we're updated to Preview1, it looks like we're encountering this error:

  • "XamlCompiler error WMC1006: Cannot resolve Assembly or Windows Metadata file '[...].dll'
  • Subfolders are all present in the bin folder after build, but no files. They were output then removed during the build.

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Aug 16, 2024

Now that we're updated to Preview1, it looks like we're encountering this error:

  • "XamlCompiler error WMC1006: Cannot resolve Assembly or Windows Metadata file '[...].dll'
  • Subfolders are all present in the bin folder after build, but no files. They were output then removed during the build.

Sounds like the issue stems from the way 1.6-preview1 has its targets ordered. The workaround is to avoid running the Clean and Build tasks at the same time on the app head. I suspect this will be fixed before the wasdk 1.6 stable release.

Arlodotexe added a commit to CommunityToolkit/Tooling-Windows-Submodule that referenced this pull request Aug 19, 2024
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Aug 22, 2024

UWP Tests ran into the random test failure #347

Closing app with package full name '7af355f7-0c20-4a39-9b71-8cf779ccfa82_1.0.0.0_x64__1v6rh0sdhj24c'.
Results File: C:\a\Windows\Windows\TestResults\uwp.trx

The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
The test running when the crash occurred: 
ConvertersExperiment.Tests.Test_BoolToObjectConverter.Test_ConvertFalseToBrush

This test may, or may not be the source of the crash.

rekicking

@Arlodotexe
Copy link
Member Author

Another random failure, this time from .NET Native:

       (BuildNativePackage target) -> 
         C:\Program Files (x86)\Microsoft SDKs\UWPNuGetPackages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): error : ILT0014: Failed to compile interop source code. See the build log for error details. [C:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\Uwp\CommunityToolkit.App.Uwp.csproj]

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! :shipit:

@Arlodotexe Arlodotexe reopened this Aug 23, 2024
@Arlodotexe Arlodotexe enabled auto-merge (rebase) August 23, 2024 19:33
auto-merge was automatically disabled August 23, 2024 19:38

Pull request was closed

@Arlodotexe Arlodotexe reopened this Aug 23, 2024
@Arlodotexe Arlodotexe enabled auto-merge (rebase) August 23, 2024 20:46
auto-merge was automatically disabled August 23, 2024 23:27

Rebase failed

@Arlodotexe Arlodotexe merged commit 4e7e574 into main Aug 24, 2024
57 of 62 checks passed
@Arlodotexe Arlodotexe deleted the wasdk/1.6 branch August 24, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants