Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _toolTip even if toolTipText isn't available #479

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

dotMorten
Copy link
Contributor

@dotMorten dotMorten commented Aug 21, 2024

Fixes

Allows adding custom content to the tooltip.
The problem with replacing the tooltipText is that the tooltip completely stops working. I want the container to still work and get placed. The code was doing an unnecessary null check on an object that wasn't being used.

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Override the style in a subclass that replaces tooltipText with something else makes tooltip stop working.

What is the new behavior?

Presence of the ToolTipText textblock is no longer required.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

This allows adding custom content to the tooltip
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dotMorten !

@Arlodotexe Arlodotexe merged commit 52755d7 into CommunityToolkit:main Sep 5, 2024
23 checks passed
@dotMorten dotMorten deleted the patch-1 branch September 5, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants