-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI when merging to dev/* branches #504
Conversation
@@ -10,7 +10,7 @@ on: | |||
push: | |||
branches: [ main, 'rel/*' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branches: [ main, 'rel/*' ] | |
branches: [ main, 'dev/*', 'rel/*' ] |
I think we need it here too, but not 100% sure. that would also let us push things in 'development' to our feeds and such, but not sure if that'll have other ramifications to which feeds and that is, but probably fine for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on: push
This section is described in the filters docs here:
the push event has a branches filter that causes your workflow to run only when a push to a branch that matches the branches filter occurs, instead of when any push occurs.
on:
push:
branches:
on: pull_request
This is described by workflow syntax docs here:
When using the
pull_request
andpull_request_target
events, you can configure a workflow to run only for pull requests that target specific branches.
on:
pull_request:
branches:
It seems like we only need to specify the branch in pull_request
, but we won't know for sure until we've merged this PR and rechecked in #500.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No dice in #500, let's try doing both then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #505
Needed for #500