Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwitchPresenter 2.0 and the new SwitchConverter 🦙❤️ #550

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Nov 1, 2024

Fixes

Note this does not make an attempt at #516 for WinUI 3, that issue still needs resolution orthogonal to these changes. The specific new functionality works fine and has been tested on UWP, WinUI 3, and Uno Platform WASM.

PR Type

What kind of change does this PR introduce?

  • New Feature

What is the current behavior?

ContentPresenter.Content is an object and can take general values/objects beyond just UIElements as it can use a ContentTemplate to transform that into UIElements.

This ability has been missing in SwitchPresenter as Case.Content was restricted to UIElement only.

We also have been able to use the same switch like power for transforming values within bindings/expressions.

What is the new behavior?

  • Case.Content is now an object
    • This allows us to use SwitchPresenter.ContentTemplate and transform data in new ways within the confines of XAML
    • You can now use a SwitchPresenter to look at a value and return some new state/configuration/object instead which then seeds your UI DataTemplate, see new sample.
    • There's probably more ways this can be leveraged, yet to be discovered
  • The core logic of SwitchPresenter has been abstracted to SwitchHelpers internal static class and generalized
    • This was done for code-reuse and simplification/separation of logic for the new SwitchConverter
    • The EvaluateCases extension is simpler and looks at the general cases to return the behavior vs. thinking about the end result
      • That is now handled by the parent
  • Introducing SwitchConverter! This infuses the power of SwitchPresenter into a IValueConverter and allows you to easily transform possible values into resources, like brushes.
    • The new sample shows this where you can take an enum status value and get the corresponding brush easily from within XAML, before this would have had to be a custom converter with custom properties, now it can all be cleanly defined in XAML

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

Note: This couldn't have been done from Labs as SwitchConverter requires the change in the base Case.Content to object as well to function, so everything would have to be duplicated. Enabling new scenarios for SwitchPresenter and sharing the code makes the most sense here.

@michael-hawker michael-hawker added enhancement New feature or request ux 🖌️ Everything design related labels Nov 1, 2024
@Arlodotexe Arlodotexe added this to the 8.2 milestone Nov 5, 2024
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, works and looks good. No major callouts, especially as it's an improvement to an existing component.

@michael-hawker
Copy link
Member Author

Added a basic (but hopefully thorough) unit test based on the sample for Switch Presenter. Ran into some issues, so opened a tracking issue here: CommunityToolkit/Tooling-Windows-Submodule#227

Pushing what I have to check against the CI, ran this test fine locally though (at least on WASDK).

Want to add one for the SwitchConverter in the morning, then we should be gtg!

@michael-hawker michael-hawker marked this pull request as ready for review November 8, 2024 17:31
Though this sample is still broken with NAOT on WinUI 3... :( Tried a couple of the suggested workarounds, but they did not work on my machine, see #516
…object Content for a Data Transformation with ContentTemplate

Tested on UWP, WinUI 3, and Uno WASM
Migrate core logic from SwitchPresenter and generlize to share between both SwitchPresenter and SwitchConverter
Added small demo of SwitchConverter to SwitchPresenter docs
Tested on UWP, WinUI 3, and Uno Platform
Validates the value changes, the case, and the content
Fix test header (failure in CI from last commit)
@michael-hawker michael-hawker enabled auto-merge (rebase) November 8, 2024 17:31
@michael-hawker michael-hawker merged commit cd19f55 into main Nov 8, 2024
24 checks passed
@michael-hawker michael-hawker deleted the llama/switch2 branch November 8, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux 🖌️ Everything design related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants