Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to profile element in the data stream #10909

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 26, 2023

Description:

Adds version numbers for profiles to the data stream based on the metadata version information.

Rationale:

To aid in future features.

Review Hints:

  1. ./build_product -j10 rhel8
  2. grep xccdf-1.2:version build/ssg-*-ds.xml

@Mab879 Mab879 added the Infrastructure Our content build system label Jul 26, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Jul 26, 2023
@Mab879
Copy link
Member Author

Mab879 commented Jul 26, 2023

cc @yuumasato @lbragstad

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mildas
Copy link
Contributor

mildas commented Jul 28, 2023

/packit retest-failed

@jan-cerny jan-cerny self-assigned this Jul 31, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

We need a test for this feature.

It would be nice to fix the code complexity although it's been very complex before.

@Mab879 Mab879 force-pushed the add_version_profile_datastream branch from a9d17a2 to 4f55423 Compare July 31, 2023 19:20
@codeclimate
Copy link

codeclimate bot commented Jul 31, 2023

Code Climate has analyzed commit 4f55423 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 requested a review from jan-cerny July 31, 2023 22:08
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built the data stream and I have viewed the version elements and their contents.

Thanks for this change!

@jan-cerny jan-cerny merged commit 28c50dc into ComplianceAsCode:master Aug 1, 2023
29 of 30 checks passed
@Mab879 Mab879 deleted the add_version_profile_datastream branch August 1, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants