Use fchmod() to prevent possible race condition

Concoctist · Oct 16, 2023 · 5cfdcfb · 5cfdcfb
1 parent 5f92662
commit 5cfdcfb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/linenoise/linenoise.c b/lib/linenoise/linenoise.c
@@ -1317,7 +1317,7 @@ int linenoiseHistorySave(const char *filename) {
     fp = fopen(filename,"w");
     umask(old_umask);
     if (fp == NULL) return -1;
-    chmod(filename,S_IRUSR|S_IWUSR);
+    fchmod(fileno(fp), S_IRUSR|S_IWUSR);
     for (j = 0; j < history_len; j++)
         fprintf(fp,"%s\n",history[j]);
     fclose(fp);