Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker/Podman support, interpret() prototype correction, operand order fix, and musl printf flush fix #72

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Docker/Podman support, interpret() prototype correction, operand order fix, and musl printf flush fix #72

merged 7 commits into from
Sep 25, 2023

Conversation

ldilley
Copy link
Member

@ldilley ldilley commented Sep 13, 2023 •
edited
Loading

Proposed Change(s)

  • Add Docker/Podman build file.
  • Update README.md to include Docker/Podman build and run steps.
  • Fix prompt display when using musl libc by calling fflush(stdout).
  • Correct interpret() prototype by adding ConcoctHashMap* map as a parameter.
  • Fix operand order bug (closes OP_DIV and OP_SUB operand stack issue #47).

@ldilley ldilley added bug Something isn't working documentation Improvements or additions to documentation new feature Request something new labels Sep 13, 2023
@ldilley ldilley added this to the 0.1.0 milestone Sep 13, 2023
@ldilley ldilley requested a review from Bamalot September 13, 2023 05:48
@ldilley ldilley self-assigned this Sep 13, 2023
@AppVeyorBot
Copy link

✅ Build concoct 0.1.51 completed (commit 8b0ef7805a by @ldilley)

@AppVeyorBot
Copy link

✅ Build concoct 0.1.151 completed (commit 8b0ef7805a by @ldilley)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AppVeyorBot
Copy link

✅ Build concoct 0.1.152 completed (commit 61aaacd37a by @ldilley)

@AppVeyorBot
Copy link

✅ Build concoct 0.1.52 completed (commit 61aaacd37a by @ldilley)

@ldilley ldilley merged commit 33b93cf into Concoctist:master Sep 25, 2023
6 checks passed
@ldilley ldilley changed the title Docker/Podman support, interpret() prototype correction, and musl printf flush fix Docker/Podman support, interpret() prototype correction, operand order fix, and musl printf flush fix Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamalot Bamalot Awaiting requested review from Bamalot

Assignees

@ldilley ldilley

@Bamalot Bamalot

Labels
bug Something isn't working documentation Improvements or additions to documentation new feature Request something new
Projects
Concoct
Status: Complete
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

OP_DIV and OP_SUB operand stack issue
3 participants
@ldilley @AppVeyorBot @Bamalot