Changes poly.* and vss.*

Cryptographer63 · Sep 19, 2023 · b081846 · b081846
1 parent eaddf94
commit b081846
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 18 deletions.
diff --git a/yacl/crypto/primitives/vss/poly.cc b/yacl/crypto/primitives/vss/poly.cc
@@ -5,8 +5,7 @@ namespace yacl::crypto {
 // Generate a random polynomial with the given zero value, threshold, and
 // modulus_.
 void Polynomial::CreatePolynomial(const math::MPInt& zero_value,
-                                  const size_t threshold,
-                                  const math::MPInt& modulus) {
+                                  size_t threshold) {
   // Create a vector to hold the polynomial coefficients.
   std::vector<math::MPInt> coefficients(threshold);
 
@@ -21,11 +20,10 @@ void Polynomial::CreatePolynomial(const math::MPInt& zero_value,
 
     // Generate a random integer less than modulus_ and assign it to
     // coefficient_i.
-    math::MPInt::RandomLtN(modulus, &coefficient_i);
+    math::MPInt::RandomLtN(this->modulus_, &coefficient_i);
 
     // Set the current coefficient to the generated random value.
     coefficients[i] = coefficient_i;
-    modulus_ = modulus;
   }
 
   // Set the generated coefficients as the coefficients of the polynomial.

diff --git a/yacl/crypto/primitives/vss/poly.h b/yacl/crypto/primitives/vss/poly.h
@@ -7,12 +7,6 @@ namespace yacl::crypto {
 // Polynomial class for polynomial manipulation and sharing.
 class Polynomial {
  public:
-  /**
-   * @brief Construct a new Polynomial object
-   *
-   */
-  Polynomial(){};
-
   /**
    * @brief Construct a new Polynomial object with modulus
    *
@@ -34,8 +28,7 @@ class Polynomial {
    * @param threshold
    * @param modulus
    */
-  void CreatePolynomial(const math::MPInt& zero_value, const size_t threshold,
-                        const math::MPInt& modulus);
+  void CreatePolynomial(const math::MPInt& zero_value, size_t threshold);
 
   /**
    * @brief Horner's method, also known as Horner's rule or Horner's scheme, is

diff --git a/yacl/crypto/primitives/vss/vss.cc b/yacl/crypto/primitives/vss/vss.cc
@@ -10,7 +10,7 @@ VerifiableSecretSharing::CreateShare(const math::MPInt& secret,
   // Create a polynomial with the secret as the constant term and random
   // coefficients.
   std::vector<math::MPInt> coefficients(this->GetThreshold());
-  poly.CreatePolynomial(secret, this->GetThreshold(), this->GetPrime());
+  poly.CreatePolynomial(secret, this->GetThreshold());
 
   std::vector<math::MPInt> xs(this->GetTotal());
   std::vector<math::MPInt> ys(this->GetTotal());
@@ -43,7 +43,7 @@ VerifiableSecretSharing::CreateShareWithCommits(
     const std::unique_ptr<yacl::crypto::EcGroup>& ecc_group, Polynomial& poly) {
   // Create a polynomial with the secret as the constant term and random
   // coefficients.
-  poly.CreatePolynomial(secret, this->threshold_, this->prime_);
+  poly.CreatePolynomial(secret, this->threshold_);
 
   std::vector<math::MPInt> xs(this->total_);
   std::vector<math::MPInt> ys(this->total_);
@@ -69,7 +69,7 @@ VerifiableSecretSharing::CreateShareWithCommits(
 
 // Recover the secret from the shares using Lagrange interpolation.
 math::MPInt VerifiableSecretSharing::RecoverSecret(
-    std::vector<VerifiableSecretSharing::Share> shares) {
+    absl::Span<const VerifiableSecretSharing::Share> shares) {
   YACL_ENFORCE(shares.size() == threshold_);
 
   math::MPInt secret(0);

diff --git a/yacl/crypto/primitives/vss/vss.h b/yacl/crypto/primitives/vss/vss.h
@@ -100,7 +100,7 @@ class VerifiableSecretSharing {
    * @param poly
    * @return math::MPInt
    */
-  math::MPInt RecoverSecret(std::vector<Share> shares);
+  math::MPInt RecoverSecret(absl::Span<const Share> shares);
 
   // New name for the type representing the result of GenerateShareWithCommits
   // function.

diff --git a/yacl/crypto/primitives/vss/vss_test.cc b/yacl/crypto/primitives/vss/vss_test.cc
@@ -24,7 +24,7 @@ TEST(VerifiableSecretSharingTest, TestCreateAndVerifyShares) {
   yacl::crypto::VerifiableSecretSharing vss(20, 10, modulus);
 
   // Initialize a polynomial for the secret sharing scheme
-  yacl::crypto::Polynomial polynomial;
+  yacl::crypto::Polynomial polynomial(modulus);
 
   // Generate shares and commitments for the secret
   using ShareAndCommitPair =
@@ -41,7 +41,6 @@ TEST(VerifiableSecretSharingTest, TestCreateAndVerifyShares) {
 
   // Reconstruct the secret using the shares and the polynomial
   math::MPInt reconstructed_secret = vss.RecoverSecret(shares);
-  SPDLOG_INFO("reconstructed_secret is : {}", reconstructed_secret);
   // Check if the reconstructed secret matches the original secret
   EXPECT_EQ(reconstructed_secret, original_secret);