Update.multiselect.component.html #539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added template renderer for group by item.
|
@CuppaLabs Can you please verify and merge the request? |
|
@purusothsv13 This does not work in a generic form. There should be a conditional application fo label or template. |
crascher
reviewed
Oct 7, 2024
| @@ -193,7 +193,7 @@ | |||
| class="pure-checkbox"> | |||
| <input *ngIf="settings.showCheckbox && !settings.singleSelection" type="checkbox" [checked]="item.selected" [disabled]="(settings.limitSelection == selectedItems?.length && !isSelected(item)) || item.disabled" | |||
| /> | |||
| <label>{{item[settings.labelKey]}}</label> | |||
There was a problem hiding this comment.
It is not related to with this PR, but maybe it helps somebody: labelKey seems to cause a problem when we use groupBy and the group ist not having a label. because the value ist not set on the item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added template renderer for group by item.