Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: this-builder #649

Merged
merged 7 commits into from
Sep 16, 2024
Merged

feat!: this-builder #649

merged 7 commits into from
Sep 16, 2024

Conversation

jkowalleck
Copy link
Member

reworked ThisTool for #635

@jkowalleck jkowalleck added this to the 8.0.0 milestone Jul 19, 2024
@jkowalleck jkowalleck requested a review from a team as a code owner July 19, 2024 16:38
@jkowalleck jkowalleck marked this pull request as draft July 19, 2024 16:42
@jkowalleck jkowalleck changed the base branch from main to 8.0.0-dev July 19, 2024 16:45
@jkowalleck jkowalleck mentioned this pull request Jul 19, 2024
Merged
@jkowalleck jkowalleck added enhancement New feature or request schema 1.5 labels Jul 27, 2024
@jkowalleck
feat!: this-builder
8c007d2 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
test res
90e78f2 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
bump dep py-serializable
175e034 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
fix serialization
68b13b8 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Merge remote-tracking branch 'origin/8.0.0-dev' into feat/this-builder
ac489b2
@jkowalleck
tests
319d452 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@codacy-production Codacy Production
Copy link

codacy-production bot commented Sep 16, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.01% ✅ 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0172564) 4625 4311 93.21%
Head commit (f9cad9f) 4635 (+10) 4321 (+10) 93.23% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#649) 13 13 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck marked this pull request as ready for review September 16, 2024 16:58
@jkowalleck
tidy
f9cad9f 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit cf5d2c7 into 8.0.0-dev Sep 16, 2024
43 checks passed
This was referenced Sep 16, 2024
Merged
Merged
jkowalleck added a commit that referenced this pull request Sep 17, 2024
@jkowalleck
tests: test builder this (#675)
e4ad3bc 
QA for #649

---------

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck deleted the feat/this-builder branch September 17, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change enhancement New feature or request schema 1.5
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jkowalleck