Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Python 3.13 support #818

Merged
merged 10 commits into from
Oct 23, 2024
Merged

feat: add Python 3.13 support #818

merged 10 commits into from
Oct 23, 2024

Conversation

jkowalleck
Copy link
Member

No description provided.

@jkowalleck jkowalleck added the enhancement New feature or request label Oct 22, 2024
@jkowalleck jkowalleck requested a review from a team as a code owner October 22, 2024 07:42
@jkowalleck jkowalleck marked this pull request as draft October 22, 2024 07:53
@jkowalleck
Copy link
Member Author

some code branches are breaking in py312, others display deprecation warnings.
will investigate and fix, so that we might release a version that is completely supporting py312.

@jkowalleck jkowalleck marked this pull request as ready for review October 22, 2024 15:39
@jkowalleck jkowalleck marked this pull request as draft October 22, 2024 16:34
@jkowalleck
Copy link
Member Author

py3.13 is working in general. no issues there.
but the tests are breaking and appear inconsistent.

py3.13 or some related thing changed how XML is done ...

-       <description>A small Python package for determining appropriate platform-specific dirs, e.g. a &quot;user data dir&quot;.</description>
?                                                                                                      ^^^^^^             ^^^^^^
+       <description>A small Python package for determining appropriate platform-specific dirs, e.g. a "user data dir".</description>
?                                                                                                      ^             ^

possible solution: modify the LIB, so taht every user input is in a CDATA block
i dont like this solution ... meee ... need to think about it.

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Copy link
Member Author

jkowalleck commented Oct 23, 2024

py3.13 is working in general. no issues there. but the tests are breaking and appear inconsistent.

py3.13 or some related thing changed how XML is done ...

-       <description>A small Python package for determining appropriate platform-specific dirs, e.g. a &quot;user data dir&quot;.</description>
?                                                                                                      ^^^^^^             ^^^^^^
+       <description>A small Python package for determining appropriate platform-specific dirs, e.g. a "user data dir".</description>
?                                                                                                      ^             ^

possible solution: modify the LIB, so taht every user input is in a CDATA block i dont like this solution ... meee ... need to think about it.

reason: python/cpython#81555

found a solution:

if sys.version_info < (3, 13):
# py3.13 finally fixed a bug in the XML writer:
# no longer escape double-quotes(") in text/non-attribute.
# here is a backwards-compat mode, so we have consistent tests.
bom = re_sub(
r'>[^<]*&quot;[^<]*<',
lambda s: s[0].replace('&quot;', '"'),
bom)

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f64ccaf) 1071 1036 96.73%
Head commit (252da20) 1071 (+0) 1036 (+0) 96.73% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#818) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck marked this pull request as ready for review October 23, 2024 09:15
@jkowalleck jkowalleck changed the title feat: App Python 3.13 support feat: add Python 3.13 support Oct 23, 2024
@jkowalleck jkowalleck merged commit f4eb79e into main Oct 23, 2024
37 checks passed
@jkowalleck jkowalleck deleted the feat/py13 branch October 23, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants