-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bibdk2021 2032 adv facets #1391
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ser super godt ud! 🎩
export default function Expand({ open, size = 3, src, bgColor }) { | ||
return ( | ||
<Icon | ||
size={size} | ||
bgColor="var(--blue)" | ||
// bgColor="var(--blue)" | ||
dataCy="expand-icon" | ||
className={`${styles.expandicon} ${open ? styles.opened : styles.closed}`} | ||
alt="expand" | ||
src="expand.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bliver bgColor og src ikke brugt ? bgColor kunne evt. have default farve på "var(--blue)". Så der mindre chance for at det påvirker de steder hvor expand bliver brugt
<div className={styles.flex}> | ||
{/*<div className={styles.countstyle}> {hitcount} </div>*/} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skal kommenteret kode fjernes?
</Title> | ||
<Title type="title6">Resultater</Title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det skal måske i Translate.json
<> | ||
<Title type="title6">Afgræns din søgning</Title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skal det ikke i translate.json? 😬
// const facets = { | ||
// facetLimit: 5, | ||
// facets: ["specificmaterialtype", "subject"], | ||
// }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fjernes 🧹
@@ -8,6 +8,8 @@ import Text from "@/components/base/text"; | |||
import Translate from "@/components/base/translate"; | |||
import isEmpty from "lodash/isEmpty"; | |||
import { formattersAndComparitors } from "@/components/search/advancedSearch/useDefaultItemsForDropdownUnits"; | |||
// import { getFacetsQuery } from "@/components/search/advancedSearch/utils"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹🧹
/> | ||
{/*<Text type="text1">{getFacetsQuery(selectedFacets)}</Text>*/} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
.accordionContainer { | ||
/*border: 2px solid blue;*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
import { useState } from "react"; | ||
import { useRouter } from "next/router"; | ||
import { AdvFacetsTypeEnum } from "@/lib/enums"; | ||
import { useAdvancedSearchContext } from "@/components/search/advancedSearch/advancedSearchContext"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det kunne være super fedt hvis vi undgår at bruge useAdvancedSearchContext i useFacets. Helst den anden vej rundt 👏
No description provided.