OIDC stubbing #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argyakrivos
reviewed
Nov 27, 2023
|
|
||
| // copy over the refresh token if its not there | ||
| // unsure if we still need the !== string 'null' check anymore | ||
| if (refreshToken && refreshToken !== 'null') { |
There was a problem hiding this comment.
I'm not sure if that's actually needed cause you handle the refresh token further down?
argyakrivos
reviewed
Nov 27, 2023
| tokenResponse.access_token = generateToken(request.keys, session) | ||
|
|
||
| // the example only checked the first item in the scope, unsure if this is correct or an oversight? | ||
| if (session.scopes[0] === 'openid') { |
There was a problem hiding this comment.
That's correct. Similarly, you only generate a refresh token if scope offline is passed.
argyakrivos
reviewed
Nov 27, 2023
|
|
||
| if (grantType !== 'refresh_token') { | ||
| logger.info('generating a refresh token') | ||
| tokenResponse.refresh_token = generateRefreshToken(request.keys, session) |
There was a problem hiding this comment.
Check my comment above on offline scope
|
Very very nice, looking good 😎 |
… endpoint for debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.