Compressed bounds #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergjoel
reviewed
Sep 14, 2023
src/pardibaal/DBM.cpp
Outdated
| std::vector<std::pair<dim_t, dim_t>> modified_bounds; | ||
| modified_bounds.reserve(dim * (dim - 1)); | ||
|
|
||
| std::vector<bool> close_zero(dim, false); |
There was a problem hiding this comment.
There is a small benchmark to be had here if it is better to keep track of the dimensions that need the zero-close or have a bit-vector like this.
With the current construction you have to iterate over dim afterwords to check if it needs closing.
In the alternative construction you have
std::vector<uint32_t> close_zero; and close_zero.push(j) on line 407 instead.
Similar can be done for "skip" -- but here you want to keep the inverse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compress bound_t struct to 32 bits.
Optimize some methods with fewer dimension calls and diagonal extrapolation to go through fewer bounds when closing. Also remove a full dbm copy from diagonal extrapolation.