Ignore ApplicationWorkHistoryBreak#application_form_id

We don't need the application_form_id on the
application_work_history_break table, we use the breakable column to
link it to an application form.

This commit ignores the application_form_id and makes sure the deletion
of the history break is going to happen when deleting a candidate, just
like before.

We made application_form_id nullable here
9d60480

app/models/application_work_history_break.rb

@@ -1,7 +1,7 @@
 class ApplicationWorkHistoryBreak < ApplicationRecord
-  belongs_to :breakable, polymorphic: true, touch: true
+  self.ignored_columns += %w[application_form_id]
 
-  before_save -> { self.application_form_id = breakable_id }, if: -> { application_form_id.nil? }
+  belongs_to :breakable, polymorphic: true, touch: true
 
   audited associated_with: :breakable
 

app/models/candidate.rb

@@ -86,6 +86,11 @@ def delete
       experienceable_id: application_form_ids,
       experienceable_type: 'ApplicationForm',
     ).delete_all
+
+    ApplicationWorkHistoryBreak.where(
+      breakable_id: application_form_ids,
+      breakable_type: 'ApplicationForm',
+    ).delete_all
   end
 
 private

app/workers/delete_test_applications.rb

@@ -23,5 +23,6 @@ def candidates_to_purge
 
   def delete_work_experiences(ids)
     ApplicationExperience.where(experienceable_id: ids, experienceable_type: 'ApplicationForm').delete_all
+    ApplicationWorkHistoryBreak.where(breakable_id: ids, breakable_type: 'ApplicationForm').delete_all
   end
 end

config/analytics.yml

@@ -190,7 +190,6 @@ shared:
     - degree_institution_uuid
     - degree_grade_uuid
   application_work_history_breaks:
-    - application_form_id
     - breakable_type
     - breakable_id
     - created_at

spec/forms/candidate_interface/restructured_work_history/work_history_break_form_spec.rb

@@ -116,12 +116,6 @@
       work_break.update(application_work_history_break)
 
       expect(application_work_history_break.reason).to eq('Updated reason.')
-      expect(application_work_history_break.breakable_id).to eq(
-        application_work_history_break.application_form_id,
-      )
-      expect(application_work_history_break.breakable_type).to eq(
-        'ApplicationForm',
-      )
     end
   end
 end

spec/models/candidate_spec.rb

@@ -82,6 +82,7 @@
       application_choice = create(:application_choice, application_form:)
       application_work_experience = create(:application_work_experience, experienceable: application_form)
       application_volunteering_experience = create(:application_volunteering_experience, experienceable: application_form)
+      application_work_history_break = create(:application_work_history_break, breakable: application_form)
       application_qualification = create(:application_qualification, application_form:)
       application_reference = create(:reference, application_form:)
 
@@ -92,6 +93,7 @@
       expect { application_choice.reload }.to raise_error(ActiveRecord::RecordNotFound)
       expect { application_work_experience.reload }.to raise_error(ActiveRecord::RecordNotFound)
       expect { application_volunteering_experience.reload }.to raise_error(ActiveRecord::RecordNotFound)
+      expect { application_work_history_break.reload }.to raise_error(ActiveRecord::RecordNotFound)
       expect { application_qualification.reload }.to raise_error(ActiveRecord::RecordNotFound)
       expect { application_reference.reload }.to raise_error(ActiveRecord::RecordNotFound)
     end