-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[171] Migration to add is_confidential
column to Reference
table
#10081
Merged
avinhurry
merged 1 commit into
main
from
migration-to-add-confidential-column-to-references-table
Nov 21, 2024
Merged
[171] Migration to add is_confidential
column to Reference
table
#10081
avinhurry
merged 1 commit into
main
from
migration-to-add-confidential-column-to-references-table
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elceebee
reviewed
Nov 20, 2024
avinhurry
force-pushed
the
migration-to-add-confidential-column-to-references-table
branch
from
November 20, 2024 21:21
557ded8
to
c95b338
Compare
avinhurry
had a problem deploying
to
review_aks
November 20, 2024 21:26
— with
GitHub Actions
Failure
dcyoung-dev
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion
avinhurry
force-pushed
the
migration-to-add-confidential-column-to-references-table
branch
from
November 21, 2024 12:29
c95b338
to
3e6893a
Compare
avinhurry
had a problem deploying
to
review_aks
November 21, 2024 12:35
— with
GitHub Actions
Failure
dcyoung-dev
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is hard 😛
avinhurry
force-pushed
the
migration-to-add-confidential-column-to-references-table
branch
from
November 21, 2024 14:49
3e6893a
to
97159b9
Compare
avinhurry
force-pushed
the
migration-to-add-confidential-column-to-references-table
branch
from
November 21, 2024 14:54
97159b9
to
0cfd7d4
Compare
avinhurry
had a problem deploying
to
review_aks
November 21, 2024 15:12
— with
GitHub Actions
Failure
dcyoung-dev
approved these changes
Nov 21, 2024
avinhurry
had a problem deploying
to
review_aks
November 21, 2024 15:31
— with
GitHub Actions
Failure
avinhurry
force-pushed
the
migration-to-add-confidential-column-to-references-table
branch
from
November 21, 2024 16:36
0cfd7d4
to
7444fde
Compare
- Send to DfE analytics
avinhurry
force-pushed
the
migration-to-add-confidential-column-to-references-table
branch
from
November 21, 2024 16:37
7444fde
to
3c40a0f
Compare
avinhurry
deleted the
migration-to-add-confidential-column-to-references-table
branch
November 21, 2024 17:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We occasionally receive requests from candidates to share references provided about them. However, the data controller is not obligated to comply with these requests.
To ensure clarity and adhere to best practices, we are updating our process to explicitly ask, at the time of collection, whether the reference can be shared with the candidate. This helps establish when a reference is provided in confidence.
This PR sets out the new column that will be used in the multistep form.
Changes proposed in this pull request
is_confidential
column toReference
table. This does has a default value oftrue
and is a boolean.Guidance to review
Things to check