Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[171] Migration to add is_confidential column to Reference table #10081

Merged

Conversation

avinhurry
Copy link
Collaborator

@avinhurry avinhurry commented Nov 20, 2024

Context

We occasionally receive requests from candidates to share references provided about them. However, the data controller is not obligated to comply with these requests.

To ensure clarity and adhere to best practices, we are updating our process to explicitly ask, at the time of collection, whether the reference can be shared with the candidate. This helps establish when a reference is provided in confidence.

This PR sets out the new column that will be used in the multistep form.

Changes proposed in this pull request

  • Migration to add is_confidential column to Reference table. This does has a default value of true and is a boolean.
  • Send to DfE analytics

Guidance to review

  • Does the column name make sense to you?
  • Does the column type make sense to you?
  • Does not setting a default value make sense to you?

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@avinhurry
Copy link
Collaborator Author

@avinhurry avinhurry added the deploy_v2 Deploy the review app to AKS label Nov 20, 2024
@github-actions github-actions bot temporarily deployed to review_aks-10081 November 20, 2024 16:36 Destroyed
@avinhurry avinhurry marked this pull request as ready for review November 20, 2024 16:53
@avinhurry avinhurry requested a review from a team November 20, 2024 16:54
@avinhurry avinhurry force-pushed the migration-to-add-confidential-column-to-references-table branch from 557ded8 to c95b338 Compare November 20, 2024 21:21
@github-actions github-actions bot temporarily deployed to review_aks-10081 November 20, 2024 21:27 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10081 November 20, 2024 22:25 Destroyed
Copy link
Collaborator

@dcyoung-dev dcyoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion

@avinhurry avinhurry force-pushed the migration-to-add-confidential-column-to-references-table branch from c95b338 to 3e6893a Compare November 21, 2024 12:29
@github-actions github-actions bot temporarily deployed to review_aks-10081 November 21, 2024 12:35 Destroyed
Copy link
Collaborator

@dcyoung-dev dcyoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is hard 😛

@avinhurry avinhurry force-pushed the migration-to-add-confidential-column-to-references-table branch from 3e6893a to 97159b9 Compare November 21, 2024 14:49
@avinhurry avinhurry force-pushed the migration-to-add-confidential-column-to-references-table branch from 97159b9 to 0cfd7d4 Compare November 21, 2024 14:54
@github-actions github-actions bot temporarily deployed to review_aks-10081 November 21, 2024 14:55 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10081 November 21, 2024 15:12 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10081 November 21, 2024 15:31 Destroyed
@avinhurry avinhurry closed this Nov 21, 2024
@avinhurry avinhurry reopened this Nov 21, 2024
@github-actions github-actions bot temporarily deployed to review_aks-10081 November 21, 2024 16:01 Destroyed
@avinhurry avinhurry force-pushed the migration-to-add-confidential-column-to-references-table branch from 0cfd7d4 to 7444fde Compare November 21, 2024 16:36
@avinhurry avinhurry force-pushed the migration-to-add-confidential-column-to-references-table branch from 7444fde to 3c40a0f Compare November 21, 2024 16:37
@github-actions github-actions bot temporarily deployed to review_aks-10081 November 21, 2024 16:42 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10081 November 21, 2024 16:54 Destroyed
@avinhurry avinhurry merged commit 5bdb18a into main Nov 21, 2024
23 checks passed
@avinhurry avinhurry deleted the migration-to-add-confidential-column-to-references-table branch November 21, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants