Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ApplicationWorkHistoryBreak#breakable column #9723

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Aug 20, 2024

Context

We migrated all the data in ba80a6f

Now we can use the breakable columns to link to an application_form

Changes proposed in this pull request

Use the breakable column

Guidance to review

Create a work break on review or locally

Peek.2024-08-20.14-24.mp4

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@CatalinVoineag CatalinVoineag self-assigned this Aug 20, 2024
@CatalinVoineag CatalinVoineag added the deploy_v2 Deploy the review app to AKS label Aug 20, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9723 August 20, 2024 09:58 Destroyed
We migrated all the data in ba80a6f

Now we can use the breakable columns to link to an application_form
@github-actions github-actions bot temporarily deployed to review_aks-9723 August 20, 2024 13:22 Destroyed
@CatalinVoineag CatalinVoineag marked this pull request as ready for review August 20, 2024 13:30
@CatalinVoineag CatalinVoineag requested a review from a team August 20, 2024 13:30

audited associated_with: :application_form

def application_form=(value)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tested by our specs already, lots of them will fail if this is not here

@CatalinVoineag CatalinVoineag merged commit 62d1402 into main Aug 20, 2024
24 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/use-breakable-column branch August 20, 2024 14:35
@inulty-dfe
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants