PWNN-2090 Store FaF data in the CMS register as 'DfE approved' frameworks(FaF Tool) #1989
+330
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwin-jebaraj
requested review from
serenaabbott11 and
threedaymonk
as code owners
threedaymonk
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Please also tidy up your branch history as in the guidelines
Test coverageLine: 87.31% |
Test coverageLine: 87.31% |
Test coverageLine: 87.14% |
Test coverageLine: 87.23% |
Test coverageLine: 87.07% |
1 similar comment
Test coverageLine: 87.07% |
Test coverageLine: 87.23% |
edwin-jebaraj
force-pushed
the
PWNN-2090-framework-register-v2
branch
from
be44e63
to
4f2c008
Compare
|
Test coverageLine: 87.23% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Story
PWNN-2090
PWNN-2092
PWNN-2095
PWNN-2096
app/components/activity_log/history_item_component.rb - Added new label for faf tool import activity
app/controllers/frameworks/frameworks_controller.rb - Added sort by option to the Provider and Provider contact
app/models/frameworks/framework.rb - Added validation
app/models/frameworks/framework/sortable.rb - Removed unwanted sortable field
app/models/frameworks/framework/sourceable.rb - Added new Source enum value for faf data import
app/models/frameworks/framework/status_changeable.rb - Updated status order and added new status value
app/services/frameworks/sync_frameworks.rb - Added framework import functionality
app/views/frameworks/frameworks/_form.html.erb - Removed unwanted fields and added condition for FaF data non editable
app/views/frameworks/frameworks/_framework.html.erb - Removed unwanted fields on Framework listing
app/views/frameworks/frameworks/_index_filters.html.erb - Removed unwanted fields on framework filter
app/views/frameworks/frameworks/_status.html.erb - Added new status colour
config/locales/validation/en.yml - Added new validation language variable
db/migrate/20241023161813_add_extra_fields_to_frameworks_frameworks.rb - Added extra fields to frameworks_frameworks table to import FaF data
db/schema.rb - updated db migration
Screen-shots or screen-capture of UI changes