Track which journey a reminder is for and use correct support email #3175
+61
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorek
force-pushed
the
LUPEYALPHA-1016-reminder-email
branch
from
026880f
to
0ab6592
Compare
slorek
changed the title
slorek
force-pushed
the
LUPEYALPHA-1016-reminder-email
branch
3 times, most recently
from
15c9877
to
c914bd5
Compare
slorek
changed the title
rjlynch
approved these changes
Sep 10, 2024
asmega
reviewed
Sep 10, 2024
kenfodder
reviewed
Sep 10, 2024
slorek
force-pushed
the
LUPEYALPHA-1016-reminder-email
branch
from
d0351c9
to
5f3373f
Compare
slorek
force-pushed
the
LUPEYALPHA-1016-reminder-email
branch
from
5f3373f
to
bd63322
Compare
slorek
force-pushed
the
LUPEYALPHA-1016-reminder-email
branch
from
bd63322
to
626b4c6
Compare
slorek
force-pushed
the
LUPEYALPHA-1016-reminder-email
branch
from
626b4c6
to
a663b7c
Compare
slorek
force-pushed
the
LUPEYALPHA-1016-reminder-email
branch
from
a663b7c
to
a62ddd0
Compare
…re for the additional payments journey
slorek
force-pushed
the
LUPEYALPHA-1016-reminder-email
branch
from
a62ddd0
to
20de7de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dfedigital.atlassian.net/browse/LUPEYALPHA-1016
At the moment the codebase assumes that all reminders are for the additional payments journey.
I've added an extra column to
Reminderto specify which journey the reminder is for, and removed the assumptions in the code in order to support reminders for other journeys.At the moment the copy in the actual reminder template that is sent when the journey is opened only accommodates the additional payments journey. I've added a failsafe to prevent reminders being sent when a different journey is opened. Now only reminders for that journey which is being opened should be sent.
Additionally when the additional payments journey was opened it would send all pending reminders, including those for other journeys. This has been fixed.
Coming back to the goal of this ticket; these changes allow us to use a different email address depending on which journey the reminder is for.