-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAPT-1797] Ops reports spike #3284
base: master
Are you sure you want to change the base?
Conversation
d00e400
to
5247399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - would check with @slorek and see if this fits with his design for the app
].freeze | ||
|
||
def initialize | ||
@claims = Claim.approved.select { |claim| Claim::MatchingAttributeFinder.new(claim).matching_claims.any? } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claims = Claim.approved.select { |claim| Claim::MatchingAttributeFinder.new(claim).matching_claims.any? } | |
@claims = Claim.approved.includes(:eligibility).select { |claim| Claim::MatchingAttributeFinder.new(claim).matching_claims.any? } |
Not sure if we want to include decisions
too or if it's less work to filter first and make the additional trips to the db
].freeze | ||
|
||
def initialize | ||
@claims = Claim.includes(:tasks) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claims = Claim.includes(:tasks) | |
@claims = Claim.includes(:tasks, :eligibility) |
].freeze | ||
|
||
def initialize | ||
@claims = Claim.includes(:tasks).where(tasks: {name: "qualifications", passed: false}).approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claims = Claim.includes(:tasks).where(tasks: {name: "qualifications", passed: false}).approved | |
@claims = Claim.includes(:tasks, :eligibility).where(tasks: {name: "qualifications", passed: false}).approved |
def change | ||
create_table :reports, id: :uuid do |t| | ||
t.string :name | ||
t.text :csv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice approach 👍, very simple and gets the job done!
Claim::DataReportRequest
class