Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move error handling #3427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Nov 22, 2024

Moves the error handling out of the ClaimStudentLoanDetailsUpdater and
into the job that calls it.
When performing an SLC upload, if the ClaimStudentLoanDetailsUpdater
errors, and swallows the error, then we can get in a scenario where the
claim doesn't have student loan details set on it but the claim does
have a passing task. As the job uses the presence of the task to
determine which claims need their details updating, subsequent SLC data
uploads don't set the claim's details.
This commit moves the error handling to wrap both the
ClaimStudentLoanDetailsUpdater and the AutomatedCheck, so we still
preserve the original intention of allowing the rest of the import to go
ahead if one of the claims is throwing an error for some reason.

Moves the error handling out of the `ClaimStudentLoanDetailsUpdater` and
into the job that calls it.
When performing an SLC upload, if the `ClaimStudentLoanDetailsUpdater`
errors, and swallows the error, then we can get in a scenario where the
claim doesn't have student loan details set on it but the claim does
have a passing task. As the job uses the presence of the task to
determine which claims need their details updating, subsequent SLC data
uploads don't set the claim's details.
This commit moves the error handling to wrap both the
`ClaimStudentLoanDetailsUpdater` and the `AutomatedCheck`, so we still
preserve the original intention of allowing the rest of the import to go
ahead if one of the claims is throwing an error for some reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant