Remove feedback component (#4046)

* Remove feedback component

* remove further redundant code

app/components/footer_component.html.erb

@@ -2,14 +2,6 @@
   <%= render Footer::TalkToUsComponent.new %>
 <% end %>
 
-<% if feedback? %>
-  <%= render Footer::FeedbackComponent.new %>
-<% end %>
-
-<% if mailing_list? %>
-  <%= render Footer::MailingListComponent.new %>
-<% end %>
-
 <%= render Footer::CookieAcceptanceComponent.new %>
 
 <footer class="site-footer">

app/components/footer_component.rb

@@ -1,20 +1,11 @@
 class FooterComponent < ViewComponent::Base
-  def initialize(talk_to_us: true, feedback: false)
+  def initialize(talk_to_us: true)
     super
 
     @talk_to_us = talk_to_us
-    @feedback = feedback
   end
 
   def talk_to_us?
     @talk_to_us
   end
-
-  def feedback?
-    @feedback
-  end
-
-  def mailing_list?
-    @mailing_list
-  end
 end

app/helpers/application_helper.rb

@@ -94,7 +94,7 @@ def sentry_dsn
   end
 
   def content_footer_kwargs(front_matter)
-    defaults = { talk_to_us: true, feedback: false }
-    defaults.merge(front_matter.symbolize_keys.slice(:talk_to_us, :feedback))
+    defaults = { talk_to_us: true }
+    defaults.merge(front_matter.symbolize_keys.slice(:talk_to_us))
   end
 end

app/views/content/help-and-support.md

@@ -7,7 +7,6 @@ description: |-
   Contact Get Into Teaching by phone or live chat and find out how to get dedicated support from an adviser, attend an event, or sign up for tailored emails.
 navigation: 40
 layout: "layouts/minimal"
-feedback: false
 talk_to_us: false
 content:
   - content/help-and-support/header

app/views/content/is-teaching-right-for-me/become-a-further-education-teacher.md

@@ -17,7 +17,6 @@ keywords:
   - BTEC
   - HND
 talk_to_us: false
-feedback: false
 ---
 
 

app/views/content/is-teaching-right-for-me/become-an-early-years-teacher.md

@@ -52,7 +52,6 @@ calls_to_action:
         Length of training: "3 months"
         Qualification: "Early years teacher status"
 talk_to_us: false
-feedback: false
 ---
 
 The early years are critical in children’s development. As an early years teacher you’ll work with young children up to the age of 5. You’ll use your knowledge and skills to help young children enjoy high standards of teaching and open their minds to new ideas every day.

app/views/layouts/category.html.erb

@@ -32,6 +32,6 @@
       <%= render(partial) %>
     <% end %>
 
-    <%= render FooterComponent.new(talk_to_us: false, feedback: false) %>
+    <%= render FooterComponent.new(talk_to_us: false) %>
   <% end %>
 </html>

app/views/layouts/feedback.html.erb

@@ -20,6 +20,6 @@
       </section>
     <% end %>
 
-    <%= render FooterComponent.new(talk_to_us: false, feedback: false) %>
+    <%= render FooterComponent.new(talk_to_us: false) %>
   <% end %>
 </html>

app/views/layouts/registration.html.erb

@@ -18,6 +18,6 @@
       </section>
     </section>
 
-    <%= render FooterComponent.new(talk_to_us: false, feedback: false) %>
+    <%= render FooterComponent.new(talk_to_us: false) %>
   <% end %>
 </html>

app/views/layouts/registration_with_image_above.html.erb

@@ -27,6 +27,6 @@
       </section>
     <% end %>
 
-    <%= render FooterComponent.new(talk_to_us: false, feedback: false) %>
+    <%= render FooterComponent.new(talk_to_us: false) %>
   <% end %>
 </html>

app/views/layouts/registration_with_side_images.html.erb

@@ -22,6 +22,6 @@
       </section>
     </div>
 
-    <%= render FooterComponent.new(talk_to_us: false, feedback: false) %>
+    <%= render FooterComponent.new(talk_to_us: false) %>
   <% end %>
 </html>

app/views/layouts/welcome.html.erb

@@ -15,6 +15,6 @@
       <% end %>
     <% end %>
 
-    <%= render FooterComponent.new(talk_to_us: true, feedback: false) %>
+    <%= render FooterComponent.new(talk_to_us: true) %>
   <% end %>
 </html>

spec/components/footer_component_spec.rb

@@ -5,17 +5,12 @@
 
   before { render }
 
-  let(:feedback_selector) { ".feedback-bar" }
   let(:talk_to_us_selector) { ".talk-to-us" }
 
   specify "renders the footer" do
     expect(page).to have_css(".site-footer")
   end
 
-  specify "renders the 'Feedback bar' by default" do
-    expect(page).not_to have_css(feedback_selector)
-  end
-
   specify "renders the 'Talk To Us' section by default" do
     expect(page).to have_css(talk_to_us_selector)
   end
@@ -24,14 +19,6 @@
     expect(page).to have_css(".cookie-acceptance")
   end
 
-  context "when feedback is disabled" do
-    subject! { render_inline(described_class.new(feedback: false)) }
-
-    specify "does not render the feedback bar" do
-      expect(page).not_to have_css(feedback_selector)
-    end
-  end
-
   context "when 'Talk to us' is disabled" do
     subject! { render_inline(described_class.new(talk_to_us: false)) }
 

spec/helpers/application_helper_spec.rb

@@ -205,12 +205,12 @@
 
     subject { content_footer_kwargs(front_matter) }
 
-    it { is_expected.to eq({ talk_to_us: true, feedback: false }) }
+    it { is_expected.to eq({ talk_to_us: true }) }
 
     context "when overriden in the front_matter" do
-      let(:front_matter) { { talk_to_us: false, feedback: false, other: false } }
+      let(:front_matter) { { talk_to_us: false, other: false } }
 
-      it { is_expected.to eq({ talk_to_us: false, feedback: false }) }
+      it { is_expected.to eq({ talk_to_us: false }) }
     end
   end
 end