Implemented Fuselage Profile Type: Superellipse ( #1016)

[merakulix]

Description

With the superellipse profile type, the CPACS standard profile type is now fully implemented.
The profile curves are generated using the functionality of the CFunctionToBSpline class with an implementation of the MathFunc3d interface.
As with the rectangle profile, this functionality means that profile curves require fewer knots than building a profile from point lists.

See also Issues #1016, #909. #1005 covered the rectangle type.

Changes in tiglcommonfunctions.* :

Added new global function that builds the wire which is needed to build profiles:

BuildWireSuperellipse(... , )

Uses the implementation of the MathFunc3d interface in an anonymos namespace:

SuperEllipse()

Changes in CCPACSFuselageProfile.* :

Added new member function that uses buildWireSuperellipse(..,) from tiglcommonfunctions.*:

BuildWiresSuperellipse(...,)

Changed member function:

BuildWires(...)

Added conditional statement to choose right method for building the wire, depending on profile type.

How Has This Been Tested?

The implementation hast been tested in Unit Tests, by creating test files, that include different test profiles, checking also the combination of different profile types with different parameters (e.g. hyper- and hypoellipses), guide curves and kinks:

new testfile:

• testFuselageStandardProfileSuperellipse.cpp

used testdata:

• simpletest_standard_profile_superellipse_guides.cpacs.xml
• simpletest_standard_profile_superellipse_kink.cpacs.xml

Screenshots, that help to understand the changes:

Several ways to combine rectangular/superelliptic profile with guide curves or a profile with kinks:

Checklist:

• A test for the new functionality was added.
• All tests run without failure.
• The new code complies with the TiGL style guide.
• New classes have been added to the Python interface.
• API changes were documented properly in tigl.h.

[codecov]

Codecov Report

Attention: Patch coverage is 96.39640% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.47%. Comparing base (8870b8f) to head (077e04c).
Report is 37 commits behind head on master.

Files with missing lines	Patch %	Lines
src/common/tiglcommonfunctions.cpp	97.67%	2 Missing ⚠️
src/fuselage/CCPACSFuselageProfile.cpp	92.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
+ Coverage   69.36%   69.47%   +0.11%     
==========================================
  Files         301      301              
  Lines       26785    26889     +104     
==========================================
+ Hits        18579    18681     +102     
- Misses       8206     8208       +2     

Flag	Coverage Δ
unittests	69.47% <96.39%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/common/tiglcommonfunctions.h	100.00% <ø> (ø)
src/common/tiglcommonfunctions.cpp	78.22% <97.67%> (+1.49%)	⬆️
src/fuselage/CCPACSFuselageProfile.cpp	85.31% <92.00%> (+1.66%)	⬆️

[joergbrech]

Just some minor changes. I checked your super ellipse points using matplotlib and they seem fine. The blue dots are the sampled points using your formulas, the green dots are the parametric form as provided on the Wikipedia page for superellipses.

superellipse_test.txt

[joergbrech]

The fuselages look awesome by the way :D

[joergbrech]

Thanks @merakulix 💐