Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce tolerance when creating cells via contourCoordinate #1026

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

svengoldberg
Copy link
Contributor

Quick fix for (the newest part of) issue #933 that causes cells to overlap.
In the long term, this procedure should be recreated in total.

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.

Quick fix for issue that causes cells to overlap. In the long term, this procedure should be recreated in total.
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.21%. Comparing base (f6f1e4c) to head (791924b).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   70.19%   70.21%   +0.01%     
==========================================
  Files         301      301              
  Lines       24429    24433       +4     
==========================================
+ Hits        17148    17155       +7     
+ Misses       7281     7278       -3     
Flag Coverage Δ
unittests 70.21% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/wing/CCPACSWingCell.cpp 78.01% <100.00%> (ø)

... and 3 files with indirect coverage changes

tests/unittests/tiglWingCell.cpp Outdated Show resolved Hide resolved
tests/unittests/tiglWingCell.cpp Show resolved Hide resolved
@joergbrech joergbrech merged commit 8870b8f into master Oct 17, 2024
17 checks passed
@joergbrech joergbrech deleted the issue_cells_overlap branch October 17, 2024 09:32
svengoldberg added a commit that referenced this pull request Nov 13, 2024
…ordwise direction

In PR #1026, the cell overlap issue was solved in spanwise direction. However, the same might appear in chordwise direction, as well. So, this tolerance is also reduced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants