-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Getter functions to CCPACSPositionings.h #1046
Open
merakulix
wants to merge
14
commits into
master
Choose a base branch
from
issue936
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
=======================================
Coverage 69.47% 69.48%
=======================================
Files 301 301
Lines 26887 26894 +7
=======================================
+ Hits 18681 18688 +7
Misses 8206 8206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I'd like to add, I formatted some docstrings that were not part of this Issue, since we discussed improving tigls generated documentation by Doxygen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Getter functions to CCPACSPositionings.h to make Positionings available via Python Bindings, which is currently not true for classes that store elements using the std::vector<std::unique_prt<TYPE>> and don't provide getter functions that return elements by index.
For further information see RISCSoftware/cpacs_tigl_gen#59
Description
New Functions:
CCPACSPositionings::GetPositioningCount()
CCPACSPositionings::GetPositioning(int index)
Implements Getter functions manually, as discussed in RISCSoftware/cpacs_tigl_gen#59, to fix missing functionality as described in #936.
Functions returning the type std::vector<std::unique_prt<TYPE>> will still not be available via Python Bindings.
How Has This Been Tested?
Added a test, checking missing functionality described in #936
Checklist: