fix(EasyOcrModel): Control if the EasyOcrModel will run on GPU based on the pipeline options and the presence of MPS #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odel. Initialize easyocr without GPU if MPS is available. Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
bbrowning
reviewed
Nov 8, 2024
There was a problem hiding this comment.
This logic looks reasonable to me - both the auto-disabling of GPU when running in a Torch with MPS enabled, and the wiring of the use_gpu parameter up to actually control the GPU usage of the easyocr.Reader. Thanks for the quick fix, and for making it as easy as possible for us downstream users to get the right Mac behavior out of the box!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EasyOcrOptions.use_gpuparameter.Checklist:
conventional commits.