Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allowing EasyOCR to use the recog_network parameter #604

Closed
wants to merge 3 commits into from
Closed

feat: Allowing EasyOCR to use the recog_network parameter #604

wants to merge 3 commits into from

Conversation

itsainii
Copy link
Contributor

@itsainii itsainii commented Dec 16, 2024 •
edited
Loading

Adding recog_network parameter of EasyOCR to allow users use their own custom recognition model.

Issue resolved by this Pull Request:
Resolves #602

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

@itsainii
Update easyocr_model.py
6cb344c 
Added this line of code to get recog_network of easyocr parameter
recog_network = self.options.recog_network


Signed-off-by: itsainii <aininawawii@gmail.com>
@itsainii
Update pipeline_options.py
424c422 
Added this line in EasyOcrOptions function

recog_network: Optional[str] = 'standard'

Signed-off-by: itsainii <aininawawii@gmail.com>
@mergify Mergify
Copy link

mergify bot commented Dec 16, 2024 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@dolfim-ibm dolfim-ibm self-requested a review December 16, 2024 08:27
@itsainii itsainii changed the title Allowing EasyOCR to use the recog_network parameter feat: Allowing EasyOCR to use the recog_network parameter Dec 16, 2024
@dolfim-ibm
Copy link
Contributor

Thanks for the PR. For letting the test pass, you have to apply the pre-commit hooks, see CONTRIBUTING.md

pre-commit run --all-files

@itsainii
Copy link
Contributor Author

Thanks for the PR. For letting the test pass, you have to apply the pre-commit hooks, see CONTRIBUTING.md

pre-commit run --all-files

I made the changes by editing the file directly in the fork on GitHub. Do I need to run the command locally, or is there a way to handle this directly on GitHub?

@dolfim-ibm
Copy link
Contributor

I made the changes by editing the file directly in the fork on GitHub. Do I need to run the command locally, or is there a way to handle this directly on GitHub?

Well, the command above will auto-update all the files to fit the styling. You can also try to fix it in the online editor (I think it is only the single vs double quotes.

@itsainii itsainii mentioned this pull request Dec 17, 2024
Merged
3 tasks
@dolfim-ibm
Copy link
Contributor

Superseded by #613

@dolfim-ibm dolfim-ibm closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfim-ibm dolfim-ibm Awaiting requested review from dolfim-ibm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allowing EasyOCR to use the recog_network parameter
2 participants
@itsainii @dolfim-ibm