Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable markdown text formatting for docx #630

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimJeg
Copy link

@SimJeg SimJeg commented Dec 19, 2024

Hi,

This PR adds markdown text formatting for docx documents (italic, bold, underline and hyperlinks). I included a new tests/data/docx/unit_test_formatting.docx document to illustrate it. Using the latest docling main the output of export_to_markdown is:

italic
bold
underline
hyperlink
italic and bold hyperlink
italic bold underline and hyperlink on the same line

with this PR it becomes:

italic
bold
underline
hyperlink
italic and bold hyperlink
italic bold underline and hyperlink on the same line

Copy link

mergify bot commented Dec 19, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg SimJeg force-pushed the docx-markdown-formatting branch from a221428 to 7f9464b Compare December 19, 2024 11:09
@SimJeg
Copy link
Author

SimJeg commented Dec 19, 2024

Note: for underline I used the <u> / </u> tags that are not rendered on GitHub 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant