Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with unofficial draft-07 schema for better hints and validation #436

Merged

Conversation

EmilyGraceSeville7cf
Copy link
Collaborator

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Sep 27, 2023

Why to make this change is explained here. Note that this schema may produce false positives like when $ref is used and title/description/type are not stated directly, but those cases can be safely ignored. It's better to get more errors when most of them are right, than get less errors and miss some real issues. :) This schema is designed to work the best with VS Code as tested just through YAML Red Hat extension.

image

Copy link
Owner

@DannyBen DannyBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I typically avoid "unofficial" anything, but since I am not a consumer of this JSON schema, I will defer to your judgment.

@DannyBen DannyBen merged commit 7cf3ef0 into master Sep 27, 2023
5 checks passed
@DannyBen DannyBen deleted the feature/partial-integration-with-unofficial-draft-07-schema branch September 27, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants