Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some incompatibilities with strict mode #446

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

DannyBen
Copy link
Owner

@DannyBen DannyBen commented Nov 13, 2023

As reported in #445 - it appears that some rendering views are incompatible with set -u strict mode, and cause an unbound variable in the rendered script. This PR fixes it and improves tests to cover this use case.

Notable changes:

  1. Some views and libraries were changed to avoid unbound variable by changing $arg['something'] to ${arg['something']:-} (or a similar syntax as appropriate).
  2. The examples spec was changed to enable strict mode before running to ensure all examples are generated in strict mode and pass tests.

@DannyBen DannyBen merged commit b0b979c into master Nov 13, 2023
6 checks passed
@DannyBen DannyBen deleted the fix/strict-mode branch November 13, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant