Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML schema as a source to the bashly JSON schema #468

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

DannyBen
Copy link
Owner

@DannyBen DannyBen commented Dec 20, 2023

An experiment to see if it is worth working with YAML as a basis for generating the bashly.json schema.

@DannyBen
Copy link
Owner Author

Tests are now passing, the schema seems to be valid now.
The only difference is that the custom-properties section is no longer called with $ref, and instead is plastered as is multiple times in the JSON file (in the YAML file, it is just once, using YAML anchors).

@EmilyGraceSeville7cf EmilyGraceSeville7cf added the enhancement New feature or request label Dec 20, 2023
@DannyBen DannyBen marked this pull request as ready for review December 21, 2023 05:31
@DannyBen DannyBen merged commit 261d104 into master Dec 21, 2023
6 checks passed
@DannyBen DannyBen deleted the add/yaml-schema-source branch December 21, 2023 05:33
@DannyBen
Copy link
Owner Author

I squash-merged, and changed the template a little to be more readable.

@DannyBen DannyBen mentioned this pull request Dec 21, 2023
5 tasks
@DannyBen
Copy link
Owner Author

@EmilyGraceSeville7cf - note that I moved the YAML source of the schema to the support folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants