Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID-1357 Use Sam for Starred Workspaces #5004

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

ID-1357 Use Sam for Starred Workspaces #5004

wants to merge 3 commits into from

Conversation

tlangs
Copy link
Contributor

@tlangs tlangs commented Aug 14, 2024 •
edited
Loading

Jira Ticket: https://broadworkbench.atlassian.net/browse/ID-1357

Summary of changes:

What

  • Use Sam for Starred Workspaces instead of the user's profile in Thurloe

Why

  • Thurloe's storage of the user profile is going away! User profile functionality is being migrated to Sam and ECM.

Testing strategy

  • Unit Tests
  • Manual Tests

@tlangs tlangs requested a review from a team as a code owner August 14, 2024 18:10
@tlangs tlangs requested a review from cahrens August 14, 2024 18:10
@cahrens cahrens removed their request for review August 15, 2024 13:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
73.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cahrens
Copy link
Contributor

cahrens commented Sep 5, 2024

@tlangs should this PR be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghost-in-a-Jar Ghost-in-a-Jar Ghost-in-a-Jar approved these changes

@blakery blakery blakery approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tlangs @cahrens @blakery @Ghost-in-a-Jar @broadbot