-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Better integrate new internal plugins #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on + uniformisation
yoannmoinet
changed the title
[DX] New internal plugins
[refactor] New internal plugins
Nov 12, 2024
yoannmoinet
force-pushed
the
yoann/new-internal-plugins
branch
2 times, most recently
from
November 14, 2024 14:34
9757247
to
82ed7f6
Compare
yoannmoinet
changed the title
[refactor] New internal plugins
[refactor] Better integrate new internal plugins
Nov 14, 2024
elbywan
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Now that we consider internal plugins almost the same as external plugins,
we need to better integrate how we create and verify them.
How?
yarn cli create-plugin
.yarn cli integrity
.Note
I will remove
Check integrity of our files
from the expected checks once this PR is merged.