Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Better integrate new internal plugins #108

Merged
merged 15 commits into from
Nov 18, 2024

Conversation

yoannmoinet
Copy link
Member

@yoannmoinet yoannmoinet commented Nov 12, 2024

What and why?

Now that we consider internal plugins almost the same as external plugins,
we need to better integrate how we create and verify them.

How?

  • Integrate their creation process in yarn cli create-plugin.
  • Integrate their verification in yarn cli integrity.
  • Update/simplify types.

Note

I will remove Check integrity of our files from the expected checks once this PR is merged.

@yoannmoinet yoannmoinet changed the title [DX] New internal plugins [refactor] New internal plugins Nov 12, 2024
@yoannmoinet yoannmoinet force-pushed the yoann/new-internal-plugins branch 2 times, most recently from 9757247 to 82ed7f6 Compare November 14, 2024 14:34
Base automatically changed from yoann/re-org-files to master November 14, 2024 16:24
@yoannmoinet yoannmoinet changed the title [refactor] New internal plugins [refactor] Better integrate new internal plugins Nov 14, 2024
@yoannmoinet yoannmoinet marked this pull request as ready for review November 14, 2024 16:58
Copy link
Member

@elbywan elbywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

packages/tools/src/commands/create-plugin/hooks.ts Outdated Show resolved Hide resolved
packages/tools/src/commands/integrity/files.ts Outdated Show resolved Hide resolved
packages/tools/src/commands/integrity/files.ts Outdated Show resolved Hide resolved
@yoannmoinet yoannmoinet merged commit b7f0408 into master Nov 18, 2024
4 checks passed
@yoannmoinet yoannmoinet deleted the yoann/new-internal-plugins branch November 18, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants