[DX] Improve tests experience #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannmoinet
commented
Sep 27, 2024
Comment on lines
-78
to
-86
| // TODO: Add support and add outputFiles to the context. | ||
| rspack(compiler) { | ||
| globalContext.bundler.rawConfig = compiler.options; | ||
| }, | ||
| farm: { | ||
| configResolved(config: any) { | ||
| globalContext.bundler.rawConfig = config; | ||
| }, | ||
| }, |
yoannmoinet
force-pushed
the
yoann/improve-tests-experience
branch
from
4eaed23
to
74f010b
Compare
elbywan
approved these changes
Sep 30, 2024
| try { | ||
| return require.resolve(filepath); | ||
| } catch (e) { | ||
| export const getAbsolutePath = (filepath: string, cwd: string) => { |
There was a problem hiding this comment.
TBH the order of the arguments confused me a bit since they are reversed when applied to path.resolve (and the leftmost cwd path ends up being the last function argument):
filepath: string, cwd: string -> path.resolve(cwd, filepath)
There was a problem hiding this comment.
Agreed, it got me a few times too.
I'll change it, just needed a little nudge to convince me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
In preparation for the internal injection plugin we need to re-enforce how we use the bundlers in our tests.
We also need to untie the GlobalContext from any plugin.
Finally, extract some helpers that will be needed for the injection plugin.
How?
runBundlersthe build will happen in a seeded directory and will return a cleaning function.getAbsolutePath,getResolvedPath,truncateStringanddoRequest.