-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Docker SSI tests to Gitlab #3445
base: main
Are you sure you want to change the base?
Conversation
27e6abf
to
52aa7f2
Compare
c0b568d
to
fb513e9
Compare
cc2982e
to
e21b8a7
Compare
cc5393d
to
53b9470
Compare
…gitlab # Conflicts: # utils/_context/_scenarios/docker_ssi.py
e227fc1
to
2a7ec9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Laplie!
In the code review only remove the "--ssi-force-build" parameter (and run again to check if the GHCR registry connectivity works)
Running the job I see flakyness on Java. I think there are problems lauching the sdk man to install Java
2024-11-19 10.19.37:* Downloading...
2024-11-19 10.19.37:�[91m
2024-11-19 10.19.37:curl: (22) The requested URL returned er�[0m
2024-11-19 10.19.37:�[91mror: 503 Service Temporarily Unavailabl�[0m
2024-11-19 10.19.37:�[91me
2024-11-19 10.19.37:�[0m
2024-11-19 10.19.37:'curl --fail --location --progress-bar "${SDKMAN_SERVICE}/broker/download/native/install/${SDKMAN_NATIVE_VERSION}/${SDKMAN_PLATFORM}" > "$sdkman_zip_file"': command failed with exit code 22.```
"script": [ | ||
"./build.sh -i runner", | ||
"source venv/bin/activate", | ||
'timeout 2700s ./run.sh DOCKER_SSI --ssi-weblog "$weblog" --ssi-library "$TEST_LIBRARY" --ssi-base-image "$base_image" --ssi-arch "$arch" --ssi-installable-runtime "$installable_runtime" --ssi-force-build', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remove the --ssi-force-build parameter
|
||
def get_free_port(): | ||
last_allowed_port = 65535 | ||
port = random.randint(1100, 65100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I very very strongly suggest to not go higher than 32000
: those port can be allocated as ephemeral ports for client connection, and you'll end with port conflict, even if the port is free when you tested it.
It was the main cause of instability of parametric tests.
Motivation
These tests need to run in Gitlab in order to access non-released versions of the tracer. Those PRs will come later
Changes
With this PR, the docker ssi tests are a child Gitlab pipeline that generated on every commit. If the pipeline was triggered from a schedule, the tests run automatically. Otherwise the tests run manually.
docker_ssi_matrix_builder.py
to generate a Gitlab pipelineget_free_port()
) rather than a hardcoded port for the agent. In Gitlab, there is already an agent runningWorkflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present