parametric: remove http_headers from otel start span creation #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdinur
changed the title
mabdinur
force-pushed
the
munir/remove-htpp-args-parame
branch
from
ced27a6
to
0e6738c
Compare
mabdinur
force-pushed
the
munir/remove-htpp-args-parame
branch
from
0e6738c
to
1bdbd9b
Compare
mabdinur
requested review from
dmehala,
emmettbutler and
romainkomorndatadog
and removed request for
a team
mabdinur
changed the title
robertomonteromiguel
requested changes
Nov 19, 2024
| with test_library.otel_start_span("otel.span") as otel_span: | ||
| current_span = test_library.current_span() | ||
| with test_library.start_span("dd_root") as dd_span: | ||
| pass |
There was a problem hiding this comment.
is this code useful?
| @@ -43,20 +43,3 @@ def test_otel_start_span_with_w3c(self, test_agent, test_library): | |||
| assert root_span["resource"] == "operation" | |||
| assert root_span["meta"]["start_attr_key"] == "start_attr_val" | |||
| assert root_span["duration"] == duration_ns | |||
|
|
|||
| @irrelevant(context.library == "cpp", reason="library does not implement OpenTelemetry") | |||
| def test_otel_span_with_w3c_headers(self, test_agent, test_library): | |||
There was a problem hiding this comment.
Could you review the manifest files? For example there is an entry for "Test_Otel_Span_With_W3c" in python.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
http_headersparameter from the/trace/otel/start_spanendpoint. The OpenTelemetry Start Span API does not support initializing spans from http headers.Changes
http_headersfromAPMLibraryClient.otel_trace_start_spanhttp_headersfromutils.parametric._library.Link. Creating otel spanlinks fromhttp_headersis also not supported by the OpenTelemetry Start Span API.http_headersstart_span argument all parameters parametric apps.Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present