Fix to work with spec compliant CAN sims. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename SimDeviceEncoderMediator.java to CANEncoderMediator.java. Rename SimDeviceMotorMediator.java to CANMotorMediator.java. Add DutyCycleMediator.java to handle SparkMaxAbsoluteEncoder and CANCoder devices. Add AnalogInputMediator.java to handle SparkMaxAnalogSensor devices. Currently passes system test but that doesn't test any of the new functionality.
CoolSpy3
requested changes
May 24, 2024
plugin/controller/src/main/java/org/team199/deepbluesim/SimRegisterer.java
Show resolved
Hide resolved
plugin/controller/src/main/java/org/team199/deepbluesim/mediators/AnalogInputMediator.java
Outdated
Show resolved
Hide resolved
plugin/controller/src/main/java/org/team199/deepbluesim/mediators/CANMotorMediator.java
Outdated
Show resolved
Hide resolved
plugin/controller/src/main/java/org/team199/deepbluesim/mediators/CANMotorMediator.java
Show resolved
Hide resolved
Rename AnalogInputMediator -> AnalogInputEncoderMediator. Fix prefix CANMotorMediator uses to detect a Spark controller. Make CANMotorMediator set sim busVoltage = 12.
CoolSpy3
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename SimDeviceEncoderMediator.java to CANEncoderMediator.java.
Rename SimDeviceMotorMediator.java to CANMotorMediator.java.
Add DutyCycleMediator.java to handle SparkMaxAbsoluteEncoder and CANCoder devices.
Add AnalogInputMediator.java to handle SparkMaxAnalogSensor devices.
Currently passes system test but that doesn't test any of the new functionality.