forked from cyberbotics/webots
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve sound support for external controller (cyberbotics#6591) (cy…
…berbotics#6605) * Improve sound support for external controller (cyberbotics#6591) Stream sound data from controller to Webots if the sound file path is accesible by the controller process. This allows external controller to use sounds even if the file path is not accessible from Webots. * Controller: Try to load sound data on controller side and stream it to webots as part of the C_SPEAKER_PLAY_SOUND message. (speaker.c) * Webots: Read controller uploaded sound data in C_SPEAKER_PLAY_SOUND message (WbSpeaker). Use former file based load method if no data was streamed from controller. * Streamed sound data is cached inside WbSpeaker instance as controller provides the data only on first use of a sound file. * Updated speaker.md to explain when wb_speaker_play_sound() streams loads the sound data itself already. * Prevent copy/assignment of WbSoundClip as it now hold a heap allocated member (mDevice). * WbSpeaker.cpp - fix source indentation * Fix comment typo in speaker.c * Address cppcheck issues * Added changelog entry for this PR Fixed ubuntu tester src formatting issue. * Fix formatting issue in WbSpeaker.cpp * Fixed bug radar.py (cyberbotics#6606) * fix bug radar.py Fixed the bug that when using Python to write a controller, using getTargets() could not correctly obtain multiple target data detected by radar * Fixed the bug in obtaining radar detection target information#6606 Fixed the bug that when using Python to write a controller, using getTargets() could not correctly obtain multiple target data detected by radar --------- Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Added changelog entry for this PR Fixed ubuntu tester src formatting issue. * Addressed code review comments cyberbotics#6605 * Incorporated review feedback Added improvement provided by CoolSpy3. * Update src/controller/c/speaker.c --------- Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Gabryel Reyes <66941456+gabryelreyes@users.noreply.github.com> Co-authored-by: lonely-poppy <77427326+lonely-poppy@users.noreply.github.com>
- Loading branch information
1 parent
1200531
commit 50ef671
Showing
7 changed files
with
149 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters