GRIDEDIT-1491 Added api function to retrieve node, edge and face-node data only #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillSenior
changed the title
…-node data Also added unit test to check successful execution of the function and failure cases , e.g. nodes array is null
BillSenior
force-pushed
the
feature/GRIDEDIT-1491_retrieve_only_necessary_data
branch
from
267942c
to
f3cb7fb
Compare
lucacarniato
approved these changes
Oct 21, 2024
| @@ -782,6 +782,32 @@ namespace meshkernelapi | |||
| return lastExitCode; | |||
| } | |||
|
|
|||
| MKERNEL_API int mkernel_mesh2d_get_data_reduced(int meshKernelId, Mesh2D& mesh2d) | |||
There was a problem hiding this comment.
should mkernel_mesh2d_get_data be substituted with mkernel_mesh2d_get_data_reduced? if this is possible we have one api less to maintain in the other layers
andreasbuykx
approved these changes
Oct 21, 2024
| @@ -1118,15 +1110,15 @@ VERBATIM_HEADERS = YES | |||
| # generated with the -Duse_libclang=ON option for CMake. | |||
| # The default value is: NO. | |||
|
|
|||
| CLANG_ASSISTED_PARSING = NO | |||
| # CLANG_ASSISTED_PARSING = NO | |||
There was a problem hiding this comment.
do the changes in this file belong to this PR?
| /// @param[in,out] mesh2d The Mesh2D data | ||
| /// @returns Error code | ||
| /// @note Only node, edge, face-node data will be retrieved (face node data include the number of nodes per face mesh2d.nodes_per_face) | ||
| MKERNEL_API int mkernel_mesh2d_get_data_reduced(int meshKernelId, Mesh2D& mesh2d); |
There was a problem hiding this comment.
Would be nice to have more descriptive names, e.g.
mkernel_mesh2d_get_connectivity (this method) and
mkernel_mesh2d_get_computed_positions (filling the edgeX, edgeY, faceX, faceY arrays).
The .._get_data can then call both (or be made obsolete).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.