-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable version of the fiat_integrator #124
Conversation
corrected raising of buildings when using datum reference
Update fiat_integrator with env_fix
Modifications made after Frederique's review. Hydromt sfincs functions are out of hydromt fiat now. Every dataset required for hydromt fiat can be done in advace with hydromt sfincs.
Makin hazard function explicit after Dirk review
Change of .rio for .raster hyndromt core function
Adding parameter geom when reading raster data. It requires that self.region is always available.
Removing test using sfincs_map.nc. They are not processed anymore through hydromt fiat.
…ltares/hydromt_fiat into #133_Spatialbuildingfootprint
#115 check and update hazard model
…_folder Clean aggregation area examples folder
Idea: make the geoms property dynamically linked to the ExposureVector class exposure_geoms property? (DATA IN THE EXPOSURE CLASS) --> make a property in fiat.py instead of the update functions, use the 'super' functions (inherit from parent class) to update the geoms property within HydroMT core) Another idea: don't store data in the class properties but only the properties that define the data. Save the data in the hydroMT classes/properties. (MORE FUNCTIONS IN EXPOSURE) Question: will the user work with HydroMT or also with the classes underneath? After solving this we will merge the fiat_integrator to the main branch |
#133 spatialbuildingfootprint
…writing the model, not before.
…model-class-that-retrieves-the-exposure_geoms-from-the-exposurevector-class 180 make a property in the fiatmodel class that retrieves the exposure geoms from the exposurevector class
The issue of saving the exposure geoms and tables in multiple places is now solved by only saving them in the geoms and tables properties in the 'write' function of the FiatModel. |
Done before requestion the review (for all except the setup_hazard function):