Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config in Dockerfile (#68) #69

Closed
wants to merge 0 commits into from
Closed

Conversation

joemat
Copy link

@joemat joemat commented Dec 20, 2023

  • run cargo clippy and fix all issues

  • run cargo fmt to format all source files

  • Extracted creation of config.toml to a script on order to make it better readable

  • Fixed putting values from environment variables to config.toml

Fixes #56

username = "$MQTT_USERNAME"
password = "$MQTT_PASSWORD"
port = $MQTT_PORT

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[simple_mqtt]
host = "$MQTT_BROKER_HOST"
username = "$MQTT_USERNAME"
password = "$MQTT_PASSWORD"
port = $MQTT_PORT

this would also publish the data using the simple MQTT publisher's topics.

@joemat
Copy link
Author

joemat commented Dec 21, 2023

sorry, had some issues with my branches, created a new PR #70 that also contains the changes suggest by you @DennisOSRM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image configuration is not working as described
2 participants